Add production Cast CRL certificate.

components/cast_certificate/cast_crl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time/time.h"
 #include "components/cast_certificate/cast_cert_validator.h"
 #include "components/cast_certificate/cast_cert_validator_test_helpers.h"
 #include "components/cast_certificate/cast_crl.h"
 #include "components/cast_certificate/proto/test_suite.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 72 matching lines @@
   if (expected_result != RESULT_SUCCESS) {
     EXPECT_FALSE(result);
     return !result;
   }
   EXPECT_TRUE(result);
   return result;
 }
 
 // Runs a single test case.
 bool RunTest(const DeviceCertTest& test_case) {
+  ResetCRLTrustAnchorForTest();

[eroman, 2016/08/03 22:47:58]

This seems problematic, in that running the tests can pollute global state for
subsequent tests.
The trust anchor is not necessarily reset here upon completion of the test (just
upon entry).

Can this be solved by one of these solutions, in order of preference.

  (a) Make the trust store an explicit dependency -- this could be done by
introducing a *ForTest() flavor of the verification function that takes a
TrustStore dependency. The advantage of this approach is tests to not mutate a
singleton, and mutation of the singleton no longer needs to be exposed. I think
this is my preferred approach.

 (b) Keep the current organization but instead of exposing a "Set/Reset*" method
for test, use a scoped setter. This ensures that override of the trust anchor is
short-lived to particular test cases or test fixtures.

 (c) Call reset in the tear down method for test fixture, so after running the
test global state is reset.

[ryanchung, 2016/08/04 18:46:43]

Done. Went with solution a).
Thanks!

+  ResetTrustAnchorForTest();
   bool use_test_trust_anchors = test_case.use_test_trust_anchors();
   if (use_test_trust_anchors) {
     const auto crl_test_root =
         cast_certificate::testing::ReadCertificateChainFromFile(
             "certificates/cast_crl_test_root_ca.pem");
     EXPECT_EQ(crl_test_root.size(), 1u);
     EXPECT_TRUE(SetCRLTrustAnchorForTest(crl_test_root[0]));
     const auto cast_test_root =
         cast_certificate::testing::ReadCertificateChainFromFile(
             "certificates/cast_test_root_ca.pem");
@@ skipping 93 matching lines @@
   }
 }
 
 TEST(CastCertificateTest, TestSuite1) {
   RunTestSuite("testsuite/testsuite1.pb");
 }
 
 }  // namespace
 
 }  // namespace cast_certificate