Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2205393002: [Sync] Merge sync_unit_tests into components_unit_tests, take 3. (Closed)

Created:
4 years, 4 months ago by maxbogue
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, jam, slan
CC:
chromium-reviews, lcwu+watch_chromium.org, mikecase+watch_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, glider+watch_chromium.org, jbudorick+watch_chromium.org, sync-reviews_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Merge sync_unit_tests into components_unit_tests, take 3. Previously reverted a couple times due to breaking bots. Since this is blocking some other stuff, I'm going to introduce a dummy target as dpranke@ suggested. BUG=626114 TBR=jam,slan Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d Cr-Commit-Position: refs/heads/master@{#409060} patch from issue 2186733002 at patchset 60001 (http://crrev.com/2186733002#ps60001) Committed: https://crrev.com/1d0b9ba2d40d0a558e543989279e54cfba36757c Cr-Commit-Position: refs/heads/master@{#409894}

Patch Set 1 #

Patch Set 2 : Add dummy target. #

Patch Set 3 : Try adding a source file to the dummy. #

Patch Set 4 : Gotta actually depend on :sync... #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -737 lines) Patch
M BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M build/all.gyp View 9 chunks +0 lines, -9 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M chromecast/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 chunks +92 lines, -2 lines 0 comments Download
M components/sync/BUILD.gn View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download
M components/sync/sync_tests.gypi View 2 chunks +0 lines, -184 lines 0 comments Download
D components/sync/sync_unit_tests_apk.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D components/sync_unit_tests.isolate View 1 chunk +0 lines, -32 lines 0 comments Download
M ios/build/bots/tests/common_tests.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.android.json View 10 chunks +0 lines, -50 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.full.json View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 39 chunks +0 lines, -223 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 6 chunks +0 lines, -41 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +0 lines, -25 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.full.json View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 2 3 4 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (30 generated)
maxbogue
Dirk, could I get your lgtm for the little dummy binary? The original change is ...
4 years, 4 months ago (2016-08-03 20:37:20 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 22:05:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205393002/80001
4 years, 4 months ago (2016-08-04 18:46:16 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-04 20:45:24 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 20:47:58 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1d0b9ba2d40d0a558e543989279e54cfba36757c
Cr-Commit-Position: refs/heads/master@{#409894}

Powered by Google App Engine
This is Rietveld 408576698