|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by Michael Hablich Modified:
4 years, 4 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Benchmark] Update Ignition benchmarks to --ignition-staging
BUG=v8:5238, v8:4863
R=machenbach@chromium.org,rmcilroy@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/4b7d1b446cc585639d048f202e525d20b88e07fa
Cr-Commit-Position: refs/heads/master@{#412238}
Patch Set 1 #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org ========== to ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
hablich@chromium.org changed reviewers: + eakuefner@chromium.org
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
On 2016/08/03 14:04:43, Michael Achenbach (slow) wrote: > lgtm lgtm, thanks. Does this also get the CallStats benchmark or is that set elsewhere?
On 2016/08/03 14:40:54, rmcilroy (OOO) wrote: > On 2016/08/03 14:04:43, Michael Achenbach (slow) wrote: > > lgtm > > lgtm, thanks. Does this also get the CallStats benchmark or is that set > elsewhere? Not that's elsewhere - I'll add you on the CL tomorrow.
On 2016/08/03 14:46:54, Michael Achenbach (slow) wrote: > On 2016/08/03 14:40:54, rmcilroy (OOO) wrote: > > On 2016/08/03 14:04:43, Michael Achenbach (slow) wrote: > > > lgtm > > > > lgtm, thanks. Does this also get the CallStats benchmark or is that set > > elsewhere? > > Not that's elsewhere - I'll add you on the CL tomorrow. I will ping Eakeufner@ and will land it. We don't need a whitespace CL for this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
On 2016/08/03 15:54:24, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build > URL) Hablich@ Did we land this change elsewhere, or is it still pending?
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/16 10:55:40, rmcilroy wrote: > On 2016/08/03 15:54:24, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no > build > > URL) > > Hablich@ Did we land this change elsewhere, or is it still pending? No, I simply forgot to check if this has landed. Sorry.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/4b7d1b446cc585639d048f202e525d20b88e07fa Cr-Commit-Position: refs/heads/master@{#412238} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4b7d1b446cc585639d048f202e525d20b88e07fa Cr-Commit-Position: refs/heads/master@{#412238} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
