Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2205303002: [Benchmark] Update Ignition benchmarks to --ignition-staging (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Benchmark] Update Ignition benchmarks to --ignition-staging BUG=v8:5238, v8:4863 R=machenbach@chromium.org,rmcilroy@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/4b7d1b446cc585639d048f202e525d20b88e07fa Cr-Commit-Position: refs/heads/master@{#412238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/v8_helper.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (14 generated)
Michael Hablich
PTAL
4 years, 4 months ago (2016-08-03 13:53:03 UTC) #5
Michael Achenbach
lgtm
4 years, 4 months ago (2016-08-03 14:04:43 UTC) #7
rmcilroy
On 2016/08/03 14:04:43, Michael Achenbach (slow) wrote: > lgtm lgtm, thanks. Does this also get ...
4 years, 4 months ago (2016-08-03 14:40:54 UTC) #8
Michael Achenbach
On 2016/08/03 14:40:54, rmcilroy (OOO) wrote: > On 2016/08/03 14:04:43, Michael Achenbach (slow) wrote: > ...
4 years, 4 months ago (2016-08-03 14:46:54 UTC) #9
Michael Hablich
On 2016/08/03 14:46:54, Michael Achenbach (slow) wrote: > On 2016/08/03 14:40:54, rmcilroy (OOO) wrote: > ...
4 years, 4 months ago (2016-08-03 14:56:07 UTC) #10
eakuefner
lgtm
4 years, 4 months ago (2016-08-03 15:12:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205303002/1
4 years, 4 months ago (2016-08-03 15:13:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-03 15:54:24 UTC) #17
rmcilroy
On 2016/08/03 15:54:24, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-16 10:55:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205303002/1
4 years, 4 months ago (2016-08-16 12:30:21 UTC) #20
Michael Hablich
On 2016/08/16 10:55:40, rmcilroy wrote: > On 2016/08/03 15:54:24, commit-bot: I haz the power wrote: ...
4 years, 4 months ago (2016-08-16 12:30:54 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/123395)
4 years, 4 months ago (2016-08-16 14:15:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205303002/1
4 years, 4 months ago (2016-08-16 14:24:18 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 15:14:22 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:15:52 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b7d1b446cc585639d048f202e525d20b88e07fa
Cr-Commit-Position: refs/heads/master@{#412238}

Powered by Google App Engine
This is Rietveld 408576698