Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bernhard's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
index d79a9b6e4f4e11c7b9b7747ac15b6217900e2685..8ceac15fcc7b16c1ffb6c3c2c2b28b3ed05058b1 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
@@ -9,7 +9,6 @@
#include <vector>
#include "base/callback_forward.h"
-#include "components/keyed_service/core/keyed_service.h"
#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/category_status.h"
@@ -28,22 +27,18 @@ namespace ntp_snippets {
// Currently, those are only the pages that the user last navigated to in an
// open tab and offlined bookmarks.
class OfflinePageSuggestionsProvider
- : public KeyedService,
- public ContentSuggestionsProvider,
+ : public ContentSuggestionsProvider,
public offline_pages::OfflinePageModel::Observer {
public:
OfflinePageSuggestionsProvider(
+ ContentSuggestionsProvider::Observer* observer,
CategoryFactory* category_factory,
offline_pages::OfflinePageModel* offline_page_model);
~OfflinePageSuggestionsProvider() override;
- // Inherited from KeyedService.
- void Shutdown() override;
-
private:
// ContentSuggestionsProvider implementation.
std::vector<Category> GetProvidedCategories() override;
- void SetObserver(ContentSuggestionsProvider::Observer* observer) override;
CategoryStatus GetCategoryStatus(Category category) override;
void DismissSuggestion(const std::string& suggestion_id) override;
void FetchSuggestionImage(const std::string& suggestion_id,
@@ -69,8 +64,6 @@ class OfflinePageSuggestionsProvider
CategoryStatus category_status_;
- ContentSuggestionsProvider::Observer* observer_;
-
offline_pages::OfflinePageModel* offline_page_model_;
const Category provided_category_;

Powered by Google App Engine
This is Rietveld 408576698