chrome/chrome_browser.gypi - Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bernhard's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/content_suggestions_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 2c165e15fa28579341444bbce4a2f0a9a3e86b81..75b0a5b4225451f3ceb999d1b9a56c7b20a7a7c8 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -394,8 +394,6 @@

'browser/net/predictor_tab_helper.h',

'browser/ntp_snippets/content_suggestions_service_factory.cc',

'browser/ntp_snippets/content_suggestions_service_factory.h',

- 'browser/ntp_snippets/ntp_snippets_service_factory.cc',

- 'browser/ntp_snippets/ntp_snippets_service_factory.h',

'browser/page_load_metrics/metrics_navigation_throttle.cc',

'browser/page_load_metrics/metrics_navigation_throttle.h',

'browser/page_load_metrics/metrics_web_contents_observer.cc',

@@ -924,8 +922,6 @@

'browser/android/ntp/ntp_snippets_bridge.h',

'browser/android/ntp/ntp_snippets_launcher.cc',

'browser/android/ntp/ntp_snippets_launcher.h',

- 'browser/android/ntp/offline_page_suggestions_provider_factory.cc',

- 'browser/android/ntp/offline_page_suggestions_provider_factory.h',

'browser/android/ntp/popular_sites.cc',

'browser/android/ntp/popular_sites.h',

'browser/android/omnibox/answers_image_bridge.cc',