chrome/browser/profiles/profile_manager.cc - Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager.cc

Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put OfflinePage things into the #if Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc ('k') | chrome/browser/ui/webui/snippets_internals_message_handler.h » ('j') | components/ntp_snippets/ntp_snippets_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager.cc

diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc

index 09c2b0f137c78f9c521cdc59f9352b75c78b0936..1c992d410357ccbe7f9db73fac8bc686aedbb1fa 100644

--- a/chrome/browser/profiles/profile_manager.cc

+++ b/chrome/browser/profiles/profile_manager.cc

@@ -107,9 +107,7 @@

#endif

#if defined(OS_ANDROID)

-#include "chrome/browser/android/ntp/offline_page_suggestions_provider_factory.h"

#include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"

-#include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"

#endif

#if defined(OS_CHROMEOS)

@@ -1229,8 +1227,6 @@ void ProfileManager::DoFinalInitForServices(Profile* profile,

#if defined(OS_ANDROID)

// Service is responsible for fetching content snippets for the NTP.

ContentSuggestionsServiceFactory::GetForProfile(profile);

Bernhard Bauer 2016/08/03 16:30:51 We could even get rid of this by overriding the fa

Philipp Keck 2016/08/03 16:45:15 Will look into that and make another CL.

- NTPSnippetsServiceFactory::GetForProfile(profile);

- OfflinePageSuggestionsProviderFactory::GetForProfile(profile);

#endif

}