Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2205233002: Combine all suggestions factories into ContentSuggestionsServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bernhard's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h" 5 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/files/file_path.h"
9 #include "base/memory/ptr_util.h"
8 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
11 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/search/suggestions/image_decoder_impl.h"
14 #include "chrome/browser/search/suggestions/suggestions_service_factory.h"
15 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
16 #include "chrome/browser/signin/signin_manager_factory.h"
17 #include "chrome/common/channel_info.h"
10 #include "chrome/common/pref_names.h" 18 #include "chrome/common/pref_names.h"
19 #include "components/image_fetcher/image_decoder.h"
20 #include "components/image_fetcher/image_fetcher.h"
21 #include "components/image_fetcher/image_fetcher_impl.h"
11 #include "components/keyed_service/content/browser_context_dependency_manager.h" 22 #include "components/keyed_service/content/browser_context_dependency_manager.h"
12 #include "components/ntp_snippets/content_suggestions_service.h" 23 #include "components/ntp_snippets/content_suggestions_service.h"
24 #include "components/ntp_snippets/ntp_snippets_constants.h"
25 #include "components/ntp_snippets/ntp_snippets_database.h"
26 #include "components/ntp_snippets/ntp_snippets_fetcher.h"
27 #include "components/ntp_snippets/ntp_snippets_scheduler.h"
28 #include "components/ntp_snippets/ntp_snippets_service.h"
29 #include "components/ntp_snippets/ntp_snippets_status_service.h"
13 #include "components/prefs/pref_service.h" 30 #include "components/prefs/pref_service.h"
31 #include "components/safe_json/safe_json_parser.h"
32 #include "components/signin/core/browser/profile_oauth2_token_service.h"
33 #include "components/signin/core/browser/signin_manager.h"
34 #include "components/version_info/version_info.h"
14 #include "content/public/browser/browser_context.h" 35 #include "content/public/browser/browser_context.h"
36 #include "content/public/browser/browser_thread.h"
37 #include "content/public/browser/storage_partition.h"
38 #include "net/url_request/url_request_context_getter.h"
15 39
16 #if defined(OS_ANDROID) 40 #if defined(OS_ANDROID)
17 #include "chrome/browser/android/chrome_feature_list.h" 41 #include "chrome/browser/android/chrome_feature_list.h"
42 #include "chrome/browser/android/ntp/ntp_snippets_launcher.h"
43 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
44 #include "components/ntp_snippets/offline_pages/offline_page_suggestions_provide r.h"
45 #include "components/offline_pages/offline_page_model.h"
46
47 using ntp_snippets::OfflinePageSuggestionsProvider;
48 using offline_pages::OfflinePageModel;
49 using offline_pages::OfflinePageModelFactory;
18 #endif // OS_ANDROID 50 #endif // OS_ANDROID
19 51
52 using content::BrowserThread;
53 using image_fetcher::ImageFetcherImpl;
54 using ntp_snippets::ContentSuggestionsService;
55 using ntp_snippets::NTPSnippetsDatabase;
56 using ntp_snippets::NTPSnippetsFetcher;
57 using ntp_snippets::NTPSnippetsService;
58 using ntp_snippets::NTPSnippetsScheduler;
59 using ntp_snippets::NTPSnippetsStatusService;
60 using suggestions::ImageDecoderImpl;
61 using suggestions::SuggestionsService;
62 using suggestions::SuggestionsServiceFactory;
63
20 // static 64 // static
21 ContentSuggestionsServiceFactory* 65 ContentSuggestionsServiceFactory*
22 ContentSuggestionsServiceFactory::GetInstance() { 66 ContentSuggestionsServiceFactory::GetInstance() {
23 return base::Singleton<ContentSuggestionsServiceFactory>::get(); 67 return base::Singleton<ContentSuggestionsServiceFactory>::get();
24 } 68 }
25 69
26 // static 70 // static
27 ntp_snippets::ContentSuggestionsService* 71 ContentSuggestionsService* ContentSuggestionsServiceFactory::GetForProfile(
28 ContentSuggestionsServiceFactory::GetForProfile(Profile* profile) { 72 Profile* profile) {
29 DCHECK(!profile->IsOffTheRecord()); 73 DCHECK(!profile->IsOffTheRecord());
30 return static_cast<ntp_snippets::ContentSuggestionsService*>( 74 return static_cast<ContentSuggestionsService*>(
31 GetInstance()->GetServiceForBrowserContext(profile, true)); 75 GetInstance()->GetServiceForBrowserContext(profile, true));
32 } 76 }
33 77
34 ContentSuggestionsServiceFactory::ContentSuggestionsServiceFactory() 78 ContentSuggestionsServiceFactory::ContentSuggestionsServiceFactory()
35 : BrowserContextKeyedServiceFactory( 79 : BrowserContextKeyedServiceFactory(
36 "ContentSuggestionsService", 80 "ContentSuggestionsService",
37 BrowserContextDependencyManager::GetInstance()) {} 81 BrowserContextDependencyManager::GetInstance()) {
82 #if defined(OS_ANDROID)
83 DependsOn(OfflinePageModelFactory::GetInstance());
84 #endif // OS_ANDROID
85 DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
86 DependsOn(SigninManagerFactory::GetInstance());
87 DependsOn(SuggestionsServiceFactory::GetInstance());
88 }
38 89
39 ContentSuggestionsServiceFactory::~ContentSuggestionsServiceFactory() {} 90 ContentSuggestionsServiceFactory::~ContentSuggestionsServiceFactory() {}
40 91
41 KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor( 92 KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
42 content::BrowserContext* context) const { 93 content::BrowserContext* context) const {
43 using State = ntp_snippets::ContentSuggestionsService::State; 94 using State = ContentSuggestionsService::State;
95 Profile* profile = Profile::FromBrowserContext(context);
44 96
45 // TODO(mvanouwerkerk): Move the enable logic into the service once we start 97 // Create the ContentSuggestionsService.
46 // observing pref changes.
47 State enabled = State::DISABLED; 98 State enabled = State::DISABLED;
48 #if defined(OS_ANDROID) 99 #if defined(OS_ANDROID)
49 // TODO(pke): Split that feature into suggestions overall and article
50 // suggestions in particular.
51 if (base::FeatureList::IsEnabled(chrome::android::kNTPSnippetsFeature)) 100 if (base::FeatureList::IsEnabled(chrome::android::kNTPSnippetsFeature))
52 enabled = State::ENABLED; 101 enabled = State::ENABLED;
53 #endif // OS_ANDROID 102 #endif // OS_ANDROID
103 ContentSuggestionsService* service = new ContentSuggestionsService(enabled);
104 if (enabled == State::DISABLED)
105 return service;
54 106
55 return new ntp_snippets::ContentSuggestionsService(enabled); 107 // Create the OfflinePageSuggestionsProvider.
108 #if defined(OS_ANDROID)
109 if (base::FeatureList::IsEnabled(
110 chrome::android::kNTPOfflinePageSuggestionsFeature)) {
111 OfflinePageModel* offline_page_model =
112 OfflinePageModelFactory::GetForBrowserContext(profile);
113
114 std::unique_ptr<OfflinePageSuggestionsProvider>
115 offline_page_suggestions_provider =
116 base::MakeUnique<OfflinePageSuggestionsProvider>(
117 service, service->category_factory(), offline_page_model);
118 service->RegisterProvider(std::move(offline_page_suggestions_provider));
119 }
120 #endif // OS_ANDROID
121
122 // Create the NTPSnippetsService (articles provider).
123 SigninManagerBase* signin_manager =
124 SigninManagerFactory::GetForProfile(profile);
125 OAuth2TokenService* token_service =
126 ProfileOAuth2TokenServiceFactory::GetForProfile(profile);
127 scoped_refptr<net::URLRequestContextGetter> request_context =
128 content::BrowserContext::GetDefaultStoragePartition(context)
129 ->GetURLRequestContext();
130 SuggestionsService* suggestions_service =
131 SuggestionsServiceFactory::GetForProfile(profile);
132 NTPSnippetsScheduler* scheduler = nullptr;
133 #if defined(OS_ANDROID)
134 scheduler = NTPSnippetsLauncher::Get();
135 #endif // OS_ANDROID
136 base::FilePath database_dir(
137 profile->GetPath().Append(ntp_snippets::kDatabaseFolder));
138 scoped_refptr<base::SequencedTaskRunner> task_runner =
139 BrowserThread::GetBlockingPool()
140 ->GetSequencedTaskRunnerWithShutdownBehavior(
141 base::SequencedWorkerPool::GetSequenceToken(),
142 base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
143 std::unique_ptr<NTPSnippetsService> ntp_snippets_service =
144 base::MakeUnique<NTPSnippetsService>(
145 service, service->category_factory(), profile->GetPrefs(),
146 suggestions_service, g_browser_process->GetApplicationLocale(),
147 scheduler, base::MakeUnique<NTPSnippetsFetcher>(
148 signin_manager, token_service, request_context,
149 profile->GetPrefs(),
150 base::Bind(&safe_json::SafeJsonParser::Parse),
151 chrome::GetChannel() == version_info::Channel::STABLE),
152 base::MakeUnique<ImageFetcherImpl>(
153 base::MakeUnique<ImageDecoderImpl>(), request_context.get()),
154 base::MakeUnique<ImageDecoderImpl>(),
155 base::MakeUnique<NTPSnippetsDatabase>(database_dir, task_runner),
156 base::MakeUnique<NTPSnippetsStatusService>(signin_manager,
157 profile->GetPrefs()));
158 service->set_ntp_snippets_service(ntp_snippets_service.get());
159 service->RegisterProvider(std::move(ntp_snippets_service));
160
161 return service;
56 } 162 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698