Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 2205203002: Change an output parameter of Maybe<T>::To() from a reference to a pointer (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change an output parameter of Maybe<T>::To() from a reference to a pointer This is a follow-up fix for https://codereview.chromium.org/2194793003/ BUG= Committed: https://crrev.com/c8241635f1dd6cf539c6dc3839b6a268b50d807c Cr-Commit-Position: refs/heads/master@{#38305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-03 06:28:18 UTC) #2
jbroman
non-owner lgtm
4 years, 4 months ago (2016-08-03 15:01:20 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-03 15:04:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205203002/1
4 years, 4 months ago (2016-08-03 15:04:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 15:06:56 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 15:10:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8241635f1dd6cf539c6dc3839b6a268b50d807c
Cr-Commit-Position: refs/heads/master@{#38305}

Powered by Google App Engine
This is Rietveld 408576698