Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2205193002: WIP: Reduce code size of InterfacePtrState (Closed)

Created:
4 years, 4 months ago by tibell
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, Dirk Pranke, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@before-sharing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce code size of InterfacePtrState InterfacePtrState is a templated class that gets expanded for every Mojo client, causing code bloat. By moving the functions that don't depend on the template parameter out of line we save roughly 900 bytes in safe_json.mojom (on Linux). BUG=597125

Patch Set 1 #

Patch Set 2 : Explicitly call parent method #

Patch Set 3 : Make destructor virtual #

Patch Set 4 : Rebase #

Patch Set 5 : No need to keep gyp up-to-date #

Patch Set 6 : Fix incorrect early return #

Patch Set 7 : Fix proxy use-before-init bug #

Patch Set 8 : git cl format #

Patch Set 9 : Shorten name to SimpleInterfacePtrState #

Patch Set 10 : Fix memory leak #

Patch Set 11 : Move SimpleInterfacePtrState::Bind out of line #

Patch Set 12 : Add missing, new .cc file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -107 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr_info.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +12 lines, -20 lines 0 comments Download
A mojo/public/cpp/bindings/interface_ptr_info.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +76 lines, -87 lines 0 comments Download
A mojo/public/cpp/bindings/lib/interface_ptr_state.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 49 (43 generated)
tibell
No need to keep gyp up-to-date
4 years, 4 months ago (2016-08-04 03:56:50 UTC) #17
tibell
Fix incorrect early return
4 years, 4 months ago (2016-08-04 04:45:08 UTC) #22
tibell
Fix proxy use-before-init bug
4 years, 4 months ago (2016-08-08 01:01:24 UTC) #28
tibell
Fix memory leak
4 years, 4 months ago (2016-08-08 04:44:09 UTC) #37
tibell
Move SimpleInterfacePtrState::Bind out of line
4 years, 4 months ago (2016-08-08 06:58:18 UTC) #42
tibell
4 years, 4 months ago (2016-08-08 07:01:14 UTC) #45
Add missing, new .cc file

Powered by Google App Engine
This is Rietveld 408576698