Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2205173003: Make SK_BUILD_FOR_WIN32 auto-detection work. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SK_BUILD_FOR_WIN32 auto-detection work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205173003 No public API changes TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/62e1a1a4ba9926c9b515eb603173ea4202ac28ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein_C
4 years, 4 months ago (2016-08-03 16:14:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205173003/1
4 years, 4 months ago (2016-08-03 16:14:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12071)
4 years, 4 months ago (2016-08-03 16:16:20 UTC) #7
herb_g
lgtm
4 years, 4 months ago (2016-08-03 18:05:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205173003/1
4 years, 4 months ago (2016-08-03 18:09:07 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 18:10:02 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62e1a1a4ba9926c9b515eb603173ea4202ac28ae

Powered by Google App Engine
This is Rietveld 408576698