Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2205163002: [MD settings] Use hand cursor for selecting site settings sites. (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] Use hand cursor for selecting site settings sites. This CL makes the sites listed in the site settings use a pointer cursor rather than a text selection cursor. It also expands the click-able area to be the row rather than just the text (per mocks). BUG=627994 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ec9312833b6e7bd909f15b55f72f49cd8431803c Cr-Commit-Position: refs/heads/master@{#409433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/site_settings/site_data.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 4 months ago (2016-08-02 23:37:02 UTC) #5
tommycli
Lgtm per offline discussion that "underscore" doesn't exist as a class.
4 years, 4 months ago (2016-08-03 00:26:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205163002/1
4 years, 4 months ago (2016-08-03 02:07:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 02:11:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 02:12:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec9312833b6e7bd909f15b55f72f49cd8431803c
Cr-Commit-Position: refs/heads/master@{#409433}

Powered by Google App Engine
This is Rietveld 408576698