Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3555)

Unified Diff: cc/output/ca_layer_overlay.cc

Issue 2205133003: Implement new RPDQ copy logic for CALayer promotion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp60_more_refactor
Patch Set: Comments from ccameron. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/ca_layer_overlay.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/ca_layer_overlay.cc
diff --git a/cc/output/ca_layer_overlay.cc b/cc/output/ca_layer_overlay.cc
index 1336e63cd6847a91689fb0bc0bd6b6515f921a42..dabfc1ee5b27f7fab4ea77ff912ad67feb1e7f76 100644
--- a/cc/output/ca_layer_overlay.cc
+++ b/cc/output/ca_layer_overlay.cc
@@ -44,6 +44,7 @@ enum CALayerResult {
CA_LAYER_FAILED_RENDER_PASS_BACKGROUND_FILTERS,
CA_LAYER_FAILED_RENDER_PASS_MASK,
CA_LAYER_FAILED_RENDER_PASS_FILTER_OPERATION,
+ CA_LAYER_FAILED_RENDER_PASS_SORTING_CONTEXT_ID,
CA_LAYER_FAILED_COUNT,
};
@@ -70,8 +71,9 @@ CALayerResult FromRenderPassQuad(ResourceProvider* resource_provider,
CALayerOverlay* ca_layer_overlay) {
if (quad->background_filters.size() != 0)
return CA_LAYER_FAILED_RENDER_PASS_BACKGROUND_FILTERS;
- if (quad->mask_resource_id() != 0)
- return CA_LAYER_FAILED_RENDER_PASS_MASK;
+
+ if (quad->shared_quad_state->sorting_context_id != 0)
+ return CA_LAYER_FAILED_RENDER_PASS_SORTING_CONTEXT_ID;
for (const FilterOperation& operation : quad->filters.operations()) {
bool success = FilterOperationSupported(operation);
@@ -79,15 +81,7 @@ CALayerResult FromRenderPassQuad(ResourceProvider* resource_provider,
return CA_LAYER_FAILED_RENDER_PASS_FILTER_OPERATION;
}
- if (quad->filters_scale != gfx::Vector2dF(1, 1)) {
- for (const FilterOperation& operation : quad->filters.operations()) {
- if (operation.type() == FilterOperation::BLUR ||
- operation.type() == FilterOperation::DROP_SHADOW) {
- return CA_LAYER_FAILED_RENDER_PASS_FILTER_SCALE;
- }
- }
- }
-
+ ca_layer_overlay->rpdq = quad;
ca_layer_overlay->contents_rect = gfx::RectF(0, 0, 1, 1);
// TODO(erikchen): Enable this when RenderPassDrawQuad promotion to CALayer
« no previous file with comments | « cc/output/ca_layer_overlay.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698