DevTools: introduce view locations, allow opening views by id.

third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Panel}
  * @implements {WebInspector.ContextMenu.Provider}
  * @implements {WebInspector.TargetManager.Observer}
+ * @implements {WebInspector.ViewLocationResolver}
  */
 WebInspector.SourcesPanel = function()
 {
     WebInspector.Panel.call(this, "sources");
     WebInspector.SourcesPanel._instance = this;
     this.registerRequiredCSS("sources/sourcesPanel.css");
     new WebInspector.DropTarget(this.element, [WebInspector.DropTarget.Types.Files], WebInspector.UIString("Drop workspace folder here"), this._handleDrop.bind(this));
 
     this._workspace = WebInspector.workspace;
     this._networkMapping = WebInspector.networkMapping;
@@ skipping 165 matching lines @@
         WebInspector.Panel.prototype.willHide.call(this);
         WebInspector.context.setFlavor(WebInspector.SourcesPanel, null);
         if (WebInspector.SourcesPanel.WrapperView.isShowing()) {
             WebInspector.SourcesPanel.WrapperView._instance._showViewInWrapper();
             WebInspector.inspectorView.setDrawerMinimized(false);
             WebInspector.SourcesPanel.updateResizer(this);
         }
     },
 
     /**
+     * @override
+     * @param {string} locationName
+     * @return {?WebInspector.ViewLocation}
+     */
+    resolveLocation: function(locationName)
+    {
+        WebInspector.inspectorView.setCurrentPanel(WebInspector.SourcesPanel.instance());
+        return this._navigatorTabbedPane;
+    },
+
+    /**
      * @return {boolean}
      */
     _ensureSourcesViewVisible: function()
     {
         if (WebInspector.SourcesPanel.WrapperView.isShowing())
             return true;
         return this === WebInspector.inspectorView.setCurrentPanel(this);
     },
 
     onResize: function()
@@ skipping 171 matching lines @@
     showUILocation: function(uiLocation, omitFocus)
     {
         this.showUISourceCode(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber, omitFocus);
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      */
     _revealInNavigator: function(uiSourceCode)
     {
-        var extensions = self.runtime.extensions("view").filter(extension => extension.descriptor()["location"] === "navigator-view");
+        var extensions = self.runtime.extensions(WebInspector.NavigatorView);
         Promise.all(extensions.map(extension => extension.instance())).then(filterNavigators);

[dgozman, 2016/08/03 19:18:18]

runtime.allInstances()

[pfeldman, 2016/08/03 21:52:18]

Done.

 
         /**
          * @param {!Array.<!Object>} objects
          */
         function filterNavigators(objects)
         {
             for (var i = 0; i < objects.length; ++i) {
                 var navigatorView = /** @type {!WebInspector.NavigatorView} */ (objects[i]);
                 if (navigatorView.accept(uiSourceCode)) {
-                    navigatorView.revealWidget();
                     navigatorView.revealUISourceCode(uiSourceCode, true);
+                    WebInspector.viewManager.showView(extensions[i].descriptor()["viewId"]);
                 }
             }
         }
     },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     _populateNavigatorMenu: function(contextMenu)
     {
@@ skipping 1030 matching lines @@
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @return {boolean}
  */
 WebInspector.SourcesPanel.WrapperView.isShowing = function()
 {
     return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.SourcesPanel.WrapperView._instance.isShowing();
 }