Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issue 2205093002: [Turbofan] Make RegisterAllocatorVerifier tolerant of shared slots. (Closed)

Created:
4 years, 4 months ago by bbudge
Modified:
4 years, 4 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Make RegisterAllocatorVerifier tolerant of shared slots. LOG=N BUG=V8:5187 Committed: https://crrev.com/b3ba7b81364b8fbc73a63883f494b5f3a263c1bb Cr-Commit-Position: refs/heads/master@{#38293}

Patch Set 1 #

Patch Set 2 : Fix fixed slots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/compiler/register-allocator-verifier.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
bbudge
4 years, 4 months ago (2016-08-02 23:17:52 UTC) #10
Mircea Trofin
On 2016/08/02 23:17:52, bbudge wrote: Lgtm
4 years, 4 months ago (2016-08-03 00:44:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205093002/20001
4 years, 4 months ago (2016-08-03 13:45:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 13:47:16 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:50:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3ba7b81364b8fbc73a63883f494b5f3a263c1bb
Cr-Commit-Position: refs/heads/master@{#38293}

Powered by Google App Engine
This is Rietveld 408576698