Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2205053002: Enable subframe FrameNavigationEntries by default. (Closed)

Created:
4 years, 4 months ago by Charlie Reis
Modified:
4 years, 4 months ago
Reviewers:
boliu, nasko
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, site-isolation-reviews_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable subframe FrameNavigationEntries by default. This is a major change to the navigation logic in Chrome, making the browser process responsible for selecting subframes to navigate. Each NavigationEntry now has a tree of FrameNavigationEntries representing each frame in the page, and these frame entries track per-frame PageState. HistoryController in content/renderer is no longer used, since equivalent code in NavigationController in content/browser now determines which frames to navigate. This CL is designed to be easy to revert if regressions are found, though the new path has been in use on 50% of Canary and Dev channels for a while. BUG=236848 TEST=Existing tests pass. Committed: https://crrev.com/111baab648276f64b58d7af5b3f47fd3823dc42e Cr-Commit-Position: refs/heads/master@{#410150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/site_isolation_policy.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Charlie Reis
We're getting ready to attempt this again, once the last back-to-dynamic-iframe.html layout test is fixed. ...
4 years, 4 months ago (2016-08-02 22:27:21 UTC) #6
boliu
lgtm
4 years, 4 months ago (2016-08-02 22:30:52 UTC) #7
nasko
Super exciting! LGTM
4 years, 4 months ago (2016-08-02 22:54:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205053002/1
4 years, 4 months ago (2016-08-05 19:52:56 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:56:43 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:58:43 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/111baab648276f64b58d7af5b3f47fd3823dc42e
Cr-Commit-Position: refs/heads/master@{#410150}

Powered by Google App Engine
This is Rietveld 408576698