Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2205013002: Revert of Put Scopes into temporary Zone (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
Reviewers:
titzer, adamk
CC:
v8-reviews_googlegroups.com, titzer, vogelheim
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Put Scopes into temporary Zone (patchset #12 id:220001 of https://codereview.chromium.org/2193793002/ ) Reason for revert: Broke Node.js tests (test-require-dot etc.) Original issue's description: > Put Scopes into temporary Zone > > When parsing a eagerly-parsed-but-lazily-compiled function, we > used to put some of its AST nodes into a discardable Zone. This > CL puts the function Scope, its inner Scopes and the related AST > nodes (Declarations, VariableProxys) into the temporary Zone > too. This reduces peak memory usage and enables future work to > keep the temporary Zone around for later compilation. > > BUG= > > Committed: https://crrev.com/eaebdd858b466057ccc39894a172c9b66868e8f7 > Cr-Commit-Position: refs/heads/master@{#38232} TBR=adamk@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/51685002a621476833bda2c0281c992c23e62d87 Cr-Commit-Position: refs/heads/master@{#38258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -345 lines) Patch
M src/ast/ast.h View 15 chunks +118 lines, -99 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ast/scopes.h View 4 chunks +3 lines, -21 lines 0 comments Download
M src/ast/scopes.cc View 7 chunks +5 lines, -70 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +87 lines, -118 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -9 lines 0 comments Download
M test/mjsunit/context-variable-assignments.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
marja
Created Revert of Put Scopes into temporary Zone
4 years, 4 months ago (2016-08-02 18:13:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2205013002/1
4 years, 4 months ago (2016-08-02 18:14:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 18:14:21 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:16:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51685002a621476833bda2c0281c992c23e62d87
Cr-Commit-Position: refs/heads/master@{#38258}

Powered by Google App Engine
This is Rietveld 408576698