Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2204983002: [TTS] Update instrumentation tests to work with Tap Suppression. (Closed)

Created:
4 years, 4 months ago by Donn Denman
Modified:
4 years, 4 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Update instrumentation tests to work with Tap Suppression. At least one instrumentation test fails due to Tap Suppression. This CL disables suppression for the existing failing test so we will test old behavior. Also remove an obsolete testing flage (since TTS is now default-on). Still TODO add new tests for suppression. BUG=633407 Committed: https://crrev.com/c6a1d0f36d226d6cd67072f0d787043ed66be252 Cr-Commit-Position: refs/heads/master@{#409533}

Patch Set 1 #

Patch Set 2 : Removed a reference to the obsolete testing flag in ContextualSearchFieldTrial. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 2 chunks +1 line, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Donn Denman
Theresa, PTAL. Thanks!
4 years, 4 months ago (2016-08-02 17:51:59 UTC) #2
Theresa
lgtm
4 years, 4 months ago (2016-08-03 00:26:40 UTC) #3
Donn Denman
Dan, Please review ChromeSwitches.java. Thanks!
4 years, 4 months ago (2016-08-03 00:38:28 UTC) #5
gone
lgtm
4 years, 4 months ago (2016-08-03 00:42:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204983002/1
4 years, 4 months ago (2016-08-03 00:44:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/106038)
4 years, 4 months ago (2016-08-03 01:03:43 UTC) #10
Donn Denman
Theresa, I missed a reference to that obsolete flag in ContextualSearchFieldTrial, PTAL at that file. ...
4 years, 4 months ago (2016-08-03 03:25:48 UTC) #11
Theresa
lgtm
4 years, 4 months ago (2016-08-03 15:52:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204983002/20001
4 years, 4 months ago (2016-08-03 15:53:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 16:35:38 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:38:10 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6a1d0f36d226d6cd67072f0d787043ed66be252
Cr-Commit-Position: refs/heads/master@{#409533}

Powered by Google App Engine
This is Rietveld 408576698