Converted Observatory class-ref & library-ref elements

Converted Observatory class-ref & library-ref elements

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/937d281f7fcef11931fc9bdeb75e16d760b8465c

[cbernaschina, 2016-08-02 21:13:48]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[Cutch, 2016-08-03 00:32:03]

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/library_ref_as_value.dart (right):

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/library_ref_as_value.dart:13: class
LibraryRefAsValueElement extends ServiceRefElement {
any reason why this is a polymer element?

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/service_ref.dart (right):

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/service_ref.dart:108: queue: app.queue);
weird indentation here

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/service_ref.dart:132: queue: app.queue);
ditto

[cbernaschina, 2016-08-03 22:12:12]

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/library_ref_as_value.dart (right):

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/library_ref_as_value.dart:13: class
LibraryRefAsValueElement extends ServiceRefElement {
On 2016/08/03 00:32:03, Cutch wrote:
> any reason why this is a polymer element?

It uses any-service-ref that is still based on polymer

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/service_ref.dart (right):

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/service_ref.dart:108: queue: app.queue);
On 2016/08/03 00:32:03, Cutch wrote:
> weird indentation here

Done.

https://codereview.chromium.org/2204973003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/service_ref.dart:132: queue: app.queue);
On 2016/08/03 00:32:03, Cutch wrote:
> ditto

Done.

[Cutch, 2016-08-04 00:00:19]

lgtm

[cbernaschina, 2016-08-04 00:48:49]

Description was changed from

==========
Converted Observatory class-ref & library-ref elements
==========

to

==========
Converted Observatory class-ref & library-ref elements

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/937d281f7fcef11931fc9bdeb75e16d760b8465c
==========

[cbernaschina, 2016-08-04 00:48:51]

Committed patchset #2 (id:20001) manually as
937d281f7fcef11931fc9bdeb75e16d760b8465c (presubmit successful).