Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2204963002: [wasm] Use the Float64Max/Min machine operators to implement F64Max/Min. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the Float64Max/Min machine operators to implement F64Max/Min. I had to adjust Float64Max/Min on x64 slightly to return the default wasm NaN (0x7FF0000000000000) instead of the all-ones NaN (0xFFFFFFFFFFFFFFFF). R=titzer@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/96c90f6c64d7a9e4a49491c4a80debd78b376bcf Cr-Commit-Position: refs/heads/master@{#38410}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated tests. #

Patch Set 3 : remove out-dated tests #

Patch Set 4 : Also the interpreter needed some adjustment #

Patch Set 5 : Float32 nans and float64 nans look differently. #

Patch Set 6 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -156 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 chunks +26 lines, -8 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 4 5 2 chunks +4 lines, -42 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 chunks +26 lines, -9 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 2 3 1 chunk +12 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 2 chunks +22 lines, -91 lines 0 comments Download

Messages

Total messages: 38 (29 generated)
ahaas
4 years, 4 months ago (2016-08-02 16:34:07 UTC) #1
Benedikt Meurer
There seems to be some cementation unhappiness. Otherwise LGTM on the TurboFan/Crankshaft parts. https://codereview.chromium.org/2204963002/diff/1/src/compiler/x64/code-generator-x64.cc File ...
4 years, 4 months ago (2016-08-03 03:24:34 UTC) #6
ahaas
The try-bots failed because I forgot to update some tests to match the new wasm ...
4 years, 4 months ago (2016-08-03 07:17:14 UTC) #9
ahaas
On 2016/08/03 at 07:17:14, ahaas wrote: > The try-bots failed because I forgot to update ...
4 years, 4 months ago (2016-08-03 09:41:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204963002/100001
4 years, 4 months ago (2016-08-05 07:26:46 UTC) #31
titzer
On 2016/08/05 07:26:46, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 4 months ago (2016-08-05 22:41:16 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204963002/100001
4 years, 4 months ago (2016-08-08 05:27:38 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-08 06:06:16 UTC) #36
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 06:06:47 UTC) #38
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/96c90f6c64d7a9e4a49491c4a80debd78b376bcf
Cr-Commit-Position: refs/heads/master@{#38410}

Powered by Google App Engine
This is Rietveld 408576698