Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2204943005: Dynamic host and port in vm-connect element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added missing space #

Patch Set 3 : Removed dump.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect_target.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-03 21:49:55 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-03 21:59:31 UTC) #3
Cutch
LGTM after removing the "dump.json" file.
4 years, 4 months ago (2016-08-04 00:00:58 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-04 00:03:37 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-04 00:20:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f1513845961818fffce2c7f60f0794b1ccbf4ed3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698