components/user_prefs/tracked/tracked_preference_helper.h - Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/tracked_preference_helper.h

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Experiment with giving two transactions to EnforceAndReport Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/user_prefs/tracked/tracked_atomic_preference.cc ('K') | « components/user_prefs/tracked/tracked_preference.h ('k') | components/user_prefs/tracked/tracked_preference_helper.cc » ('j') | components/user_prefs/tracked/tracked_preference_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_prefs/tracked/tracked_preference_helper.h

diff --git a/components/user_prefs/tracked/tracked_preference_helper.h b/components/user_prefs/tracked/tracked_preference_helper.h

index 883e3e8f78908062497b0197460e5be3c7025145..8f2e188d8720f2ebabd49752c5d238adeab6af16 100644

--- a/components/user_prefs/tracked/tracked_preference_helper.h

+++ b/components/user_prefs/tracked/tracked_preference_helper.h

@@ -10,6 +10,7 @@

#include <string>

#include "base/macros.h"

+#include "components/user_prefs/tracked/hash_store_contents.h"

#include "components/user_prefs/tracked/pref_hash_filter.h"

#include "components/user_prefs/tracked/pref_hash_store_transaction.h"

@@ -42,8 +43,8 @@ class TrackedPreferenceHelper {

bool IsPersonal() const;

// Reports |value_state| via UMA under |reporting_id_|.

gab 2016/08/03 18:19:36 // Reports |value_state| via UMA under |reporting_

proberge 2016/08/04 00:13:47 Done, but keeping |validation_type| for now.

- void ReportValidationResult(

- PrefHashStoreTransaction::ValueState value_state) const;

+ void ReportValidationResult(PrefHashStoreTransaction::ValueState value_state,

+ HashStoreContentsType validation_type) const;

gab 2016/08/03 18:19:36 As mentioned above, I think this could just be co

proberge 2016/08/04 00:13:47 Ack, see above reply

// Reports |reset_action| via UMA under |reporting_id_|.

void ReportAction(ResetAction reset_action) const;