components/user_prefs/tracked/tracked_atomic_preference.h - Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/tracked_atomic_preference.h

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Experiment with giving two transactions to EnforceAndReport Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc ('K') | « components/user_prefs/tracked/registry_hash_store_contents_win_unittest.cc ('k') | components/user_prefs/tracked/tracked_atomic_preference.cc » ('j') | components/user_prefs/tracked/tracked_atomic_preference.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_prefs/tracked/tracked_atomic_preference.h

diff --git a/components/user_prefs/tracked/tracked_atomic_preference.h b/components/user_prefs/tracked/tracked_atomic_preference.h

index 04bd0eaae8520c091810d376ba1ca5e918f0e133..9d7601fa5b107fa3d0b7268928615f1f55481174 100644

--- a/components/user_prefs/tracked/tracked_atomic_preference.h

+++ b/components/user_prefs/tracked/tracked_atomic_preference.h

@@ -32,8 +32,10 @@ class TrackedAtomicPreference : public TrackedPreference {

// TrackedPreference implementation.

void OnNewValue(const base::Value* value,

PrefHashStoreTransaction* transaction) const override;

- bool EnforceAndReport(base::DictionaryValue* pref_store_contents,

- PrefHashStoreTransaction* transaction) const override;

+ bool EnforceAndReport(

+ base::DictionaryValue* pref_store_contents,

+ PrefHashStoreTransaction* transaction,

+ PrefHashStoreTransaction* registry_transaction) const override;

gab 2016/08/03 18:19:36 |external_valiation_transaction|

proberge 2016/08/04 00:13:46 Done.

private:

const std::string pref_path_;