Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/prefs/json_pref_store.h

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply comments from patch set 27 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | components/prefs/json_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/json_pref_store.h
diff --git a/components/prefs/json_pref_store.h b/components/prefs/json_pref_store.h
index 5b52360cfb2539ffe307ee65da4b22c8b9a87ef8..170ccb1161d405f36920850d73358a3e0703c5bc 100644
--- a/components/prefs/json_pref_store.h
+++ b/components/prefs/json_pref_store.h
@@ -190,11 +190,11 @@ class COMPONENTS_PREFS_EXPORT JsonPrefStore
void RunOrScheduleNextSuccessfulWriteCallback(bool write_success);
// Handles the result of a write with result |write_success|. Runs
- // |on_next_write| callback on the current thread and posts
- // |RunOrScheduleNextSuccessfulWriteCallback| on |reply_task_runner|.
+ // |on_next_write_callback| on the current thread and posts
+ // |on_next_write_reply| on |reply_task_runner|.
static void PostWriteCallback(
- const base::Callback<void(bool success)>& on_next_write_reply,
const base::Callback<void(bool success)>& on_next_write_callback,
+ const base::Callback<void(bool success)>& on_next_write_reply,
scoped_refptr<base::SequencedTaskRunner> reply_task_runner,
bool write_success);
@@ -252,8 +252,7 @@ class COMPONENTS_PREFS_EXPORT JsonPrefStore
std::set<std::string> keys_need_empty_value_;
- bool has_pending_successful_write_reply_;
- bool has_pending_write_callbacks_;
+ bool has_pending_write_reply_ = true;
base::Closure on_next_successful_write_reply_;
WriteCountHistogram write_count_histogram_;
« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | components/prefs/json_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698