components/prefs/json_pref_store.h - Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/json_pref_store.h

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify has_pending_write_reply/callback booleans and logic Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/prefs/json_pref_store.h

diff --git a/components/prefs/json_pref_store.h b/components/prefs/json_pref_store.h

index 5b52360cfb2539ffe307ee65da4b22c8b9a87ef8..a1139d7cef1c278ba58e074826d4f987c066ed2b 100644

--- a/components/prefs/json_pref_store.h

+++ b/components/prefs/json_pref_store.h

@@ -252,8 +252,7 @@ class COMPONENTS_PREFS_EXPORT JsonPrefStore

std::set<std::string> keys_need_empty_value_;

- bool has_pending_successful_write_reply_;

- bool has_pending_write_callbacks_;

+ bool has_pending_write_reply_ = true;

base::Closure on_next_successful_write_reply_;

WriteCountHistogram write_count_histogram_;

« no previous file with comments | « chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('k') | components/prefs/json_pref_store.cc » ('j') | components/prefs/json_pref_store.cc » ('J')