components/prefs/json_pref_store_unittest.cc - Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/json_pref_store_unittest.cc

Issue 2204943002: Integrate registry_hash_store_contents with the rest of tracked prefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unit and browser tests. GetType => GetUMASuffix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/tracked/pref_hash_browsertest.cc ('K') | « components/prefs/json_pref_store.cc ('k') | components/prefs/pref_filter.h » ('j') | components/user_prefs/tracked/pref_hash_filter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/prefs/json_pref_store_unittest.cc

diff --git a/components/prefs/json_pref_store_unittest.cc b/components/prefs/json_pref_store_unittest.cc

index 18299e24ddb6995820258a994ea7233f3272ba15..9da62733bc0968ae36d661daf899240dba0aefb9 100644

--- a/components/prefs/json_pref_store_unittest.cc

+++ b/components/prefs/json_pref_store_unittest.cc

@@ -75,8 +75,10 @@ class InterceptingPrefFilter : public PrefFilter {

const PostFilterOnLoadCallback& post_filter_on_load_callback,

std::unique_ptr<base::DictionaryValue> pref_store_contents) override;

void FilterUpdate(const std::string& path) override {}

- void FilterSerializeData(

- base::DictionaryValue* pref_store_contents) override {}

+ base::Callback<void(bool)> FilterSerializeData(

+ base::DictionaryValue* pref_store_contents) override {

+ return base::Callback<void(bool)>();

+ }

bool has_intercepted_prefs() const { return intercepted_prefs_ != NULL; }