Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 220493003: Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (including 227613008) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_parser.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc
index 1fb64ef7521eb8ac9a62748d8eec75e055ad4eab..450bd12c7a39f887ffdddff32b2b1f738f9647ce 100644
--- a/chrome/browser/safe_browsing/protocol_parser.cc
+++ b/chrome/browser/safe_browsing/protocol_parser.cc
@@ -66,7 +66,8 @@ bool SafeBrowsingProtocolParser::ParseGetHash(
SBFullHashResult full_hash;
full_hash.list_name = cmd_parts[0];
- full_hash.add_chunk_id = atoi(cmd_parts[1].c_str());
+ // Ignore cmd_parts[1] (add_chunk_id), as we no longer use it with SB 2.3
+ // caching rules.
int full_hash_len = atoi(cmd_parts[2].c_str());
// Ignore hash results from lists we don't recognize.
« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698