Safebrowsing: change gethash caching to match api 2.3 rules, fix some corner cases.

chrome/browser/safe_browsing/protocol_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Parse the data returned from the SafeBrowsing v2.1 protocol response.
 
 #include <stdlib.h>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
@@ skipping 48 matching lines @@
     data += offset;
     length -= offset;
 
     std::vector<std::string> cmd_parts;
     base::SplitString(line, ':', &cmd_parts);
     if (cmd_parts.size() != 3)
       return false;
 
     SBFullHashResult full_hash;
     full_hash.list_name = cmd_parts[0];
-    full_hash.add_chunk_id = atoi(cmd_parts[1].c_str());
+    // Ignore cmd_parts[1] (add_chunk_id), as we no longer use it with SB 2.3
+    // caching rules.
     int full_hash_len = atoi(cmd_parts[2].c_str());
 
     // Ignore hash results from lists we don't recognize.
     if (safe_browsing_util::GetListId(full_hash.list_name) < 0) {
       data += full_hash_len;
       length -= full_hash_len;
       continue;
     }
 
     while (full_hash_len > 0) {
@@ skipping 334 matching lines @@
       memcpy(&hash, *data, sizeof(hash));
       entry->SetFullHashAt(i, hash);
     }
     *data += hash_len;
     *remaining -= hash_len;
     DCHECK_GE(*remaining, 0);
   }
 
   return true;
 }