third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h - Issue 2204923002: Untangle HarfBuzz callbacks for glyph width and extents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h

Issue 2204923002: Untangle HarfBuzz callbacks for glyph width and extents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Untangle HarfBuzz callbacks for glyph width and extents Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp ('k') | third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h

diff --git a/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h b/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h

index ca85fa424f479c3f0133fdc73179fc031d36753c..a4948c8876a17ba7db3aeb6e4aee50222bee2552 100644

--- a/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h

+++ b/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.h

@@ -16,7 +16,8 @@ class SkiaTextMetrics final {

public:

SkiaTextMetrics(const SkPaint*);

- void getGlyphWidthAndExtentsForHarfBuzz(hb_codepoint_t, hb_position_t* width, hb_glyph_extents_t*);

+ void getGlyphWidthForHarfBuzz(hb_codepoint_t, hb_position_t* width);

+ void getGlyphExtentsForHarfBuzz(hb_codepoint_t, hb_glyph_extents_t*);

void getSkiaBoundsForGlyph(Glyph, SkRect* bounds);

float getSkiaWidthForGlyph(Glyph);