Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2204893002: Add Map::weak_cell_cache internal link to heap snapshot. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add Map::weak_cell_cache internal link to heap snapshot. Committed: https://crrev.com/0a920f607f3dab1d807e166f134c8244d7d733a1 Cr-Commit-Position: refs/heads/master@{#38244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/profiler/heap-snapshot-generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 4 months ago (2016-08-02 12:08:24 UTC) #2
ulan
lgtm
4 years, 4 months ago (2016-08-02 12:11:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204893002/1
4 years, 4 months ago (2016-08-02 12:17:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 13:02:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 13:06:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a920f607f3dab1d807e166f134c8244d7d733a1
Cr-Commit-Position: refs/heads/master@{#38244}

Powered by Google App Engine
This is Rietveld 408576698