|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by allada Modified:
4 years, 4 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Preview view in network should always show data
Fixed bug where Preview tab in network would not show the data after
navigating to Response tab.
BUG=630729
Committed: https://crrev.com/84501401aa1121fbb902385426d2428d375cacba
Cr-Commit-Position: refs/heads/master@{#409409}
Patch Set 1 #
Total comments: 2
Patch Set 2 : [Devtools] Preview view in network should always #Messages
Total messages: 17 (9 generated)
allada@chromium.org changed reviewers: + lushnikov@chromium.org
PTL
Description was changed from ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 ========== to ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 ==========
allada@chromium.org changed reviewers: + dgozman@chromium.org
lgtm https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js (right): https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js:70: function handlePreviewView(view) { style: while you are here, place { on next line
https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js (right): https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js:70: function handlePreviewView(view) { On 2016/08/02 02:51:43, dgozman wrote: > style: while you are here, place { on next line Done.
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2204803002/#ps20001 (title: "[Devtools] Preview view in network should always")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 ========== to ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 ========== to ========== [Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 Committed: https://crrev.com/84501401aa1121fbb902385426d2428d375cacba Cr-Commit-Position: refs/heads/master@{#409409} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/84501401aa1121fbb902385426d2428d375cacba Cr-Commit-Position: refs/heads/master@{#409409} |
