Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2204803002: [Devtools] Preview view in network should always show data (Closed)

Created:
4 years, 4 months ago by allada
Modified:
4 years, 4 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Preview view in network should always show data Fixed bug where Preview tab in network would not show the data after navigating to Response tab. BUG=630729 Committed: https://crrev.com/84501401aa1121fbb902385426d2428d375cacba Cr-Commit-Position: refs/heads/master@{#409409}

Patch Set 1 #

Total comments: 2

Patch Set 2 : [Devtools] Preview view in network should always #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
allada
PTL
4 years, 4 months ago (2016-08-02 01:45:37 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js File third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js (right): https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js#newcode70 third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js:70: function handlePreviewView(view) { style: while you are here, ...
4 years, 4 months ago (2016-08-02 02:51:43 UTC) #5
allada
https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js File third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js (right): https://codereview.chromium.org/2204803002/diff/1/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js#newcode70 third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js:70: function handlePreviewView(view) { On 2016/08/02 02:51:43, dgozman wrote: > ...
4 years, 4 months ago (2016-08-02 16:59:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204803002/20001
4 years, 4 months ago (2016-08-02 17:00:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/114537)
4 years, 4 months ago (2016-08-02 18:23:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204803002/20001
4 years, 4 months ago (2016-08-02 23:43:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 00:58:44 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 01:01:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84501401aa1121fbb902385426d2428d375cacba
Cr-Commit-Position: refs/heads/master@{#409409}

Powered by Google App Engine
This is Rietveld 408576698