Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2204773002: Remove extra method from LocationUtils (Closed)

Created:
4 years, 4 months ago by cco3
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extra method from LocationUtils LocationUtils has an implementation of isSystemLocationSettingEnabled that unecessarily takes a Context parameter. This change removes that method. BUG=631244 Committed: https://crrev.com/c3e122b0407fcc39898a46a3ac7db9d16f5a0efd Cr-Commit-Position: refs/heads/master@{#409242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M components/location/android/java/src/org/chromium/components/location/LocationUtils.java View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
cco3
Hi Ted, this is the last followup on the LocationUtils change.
4 years, 4 months ago (2016-08-02 16:38:46 UTC) #2
Ted C
lgtm
4 years, 4 months ago (2016-08-02 16:41:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204773002/1
4 years, 4 months ago (2016-08-02 17:30:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 18:12:01 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:13:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e122b0407fcc39898a46a3ac7db9d16f5a0efd
Cr-Commit-Position: refs/heads/master@{#409242}

Powered by Google App Engine
This is Rietveld 408576698