Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2204743003: [tracing] Increase backtrace map capacity on Linux. (Closed)

Created:
4 years, 4 months ago by Dmitry Skiba
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Increase backtrace map capacity on Linux. On Linux when startup tracing is used with native heap profiling, ~45K unique backtraces are generated, while backtrace map only allows for 32K. This CL bumps the max number of unique backtraces. BUG=633309 Committed: https://crrev.com/ece847f3cd16baa05a9b896ba7ae58b23540a178 Cr-Commit-Position: refs/heads/master@{#410203}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M base/trace_event/heap_profiler_allocation_register.h View 2 chunks +9 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Dmitry Skiba
4 years, 4 months ago (2016-08-01 23:33:14 UTC) #2
Primiano Tucci (use gerrit)
LGTM https://codereview.chromium.org/2204743003/diff/1/base/trace_event/heap_profiler_allocation_register.h File base/trace_event/heap_profiler_allocation_register.h (right): https://codereview.chromium.org/2204743003/diff/1/base/trace_event/heap_profiler_allocation_register.h#newcode313 base/trace_event/heap_profiler_allocation_register.h:313: static const size_t kBacktraceCapacity = 55000; // 45K ...
4 years, 4 months ago (2016-08-03 13:15:01 UTC) #3
Dmitry Skiba
On 2016/08/03 13:15:01, Primiano Tucci wrote: > LGTM > > https://codereview.chromium.org/2204743003/diff/1/base/trace_event/heap_profiler_allocation_register.h > File base/trace_event/heap_profiler_allocation_register.h (right): ...
4 years, 4 months ago (2016-08-05 21:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204743003/1
4 years, 4 months ago (2016-08-05 21:34:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 22:51:01 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:52:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ece847f3cd16baa05a9b896ba7ae58b23540a178
Cr-Commit-Position: refs/heads/master@{#410203}

Powered by Google App Engine
This is Rietveld 408576698