Make stray 'return' an early error

Make stray 'return' an early error

As required by the spec, and implemented by other browsers.

(Plus minor clean-up for redeclaration TypeErrors.)

R=marja@chromium.org
BUG=
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=20434

[marja, 2014-04-02 12:29:57]

lgtm

https://codereview.chromium.org/220473014/diff/1/src/runtime.cc
File src/runtime.cc (left):

https://codereview.chromium.org/220473014/diff/1/src/runtime.cc#oldcode2205
src/runtime.cc:2205: return ThrowRedeclarationError(isolate, "function", name);
Why don't we differentiate between "function", "const" and "var" redeclaration
any more?

[rossberg, 2014-04-02 12:34:43]

https://codereview.chromium.org/220473014/diff/1/src/runtime.cc
File src/runtime.cc (left):

https://codereview.chromium.org/220473014/diff/1/src/runtime.cc#oldcode2205
src/runtime.cc:2205: return ThrowRedeclarationError(isolate, "function", name);
On 2014/04/02 12:29:57, marja wrote:
> Why don't we differentiate between "function", "const" and "var" redeclaration
> any more?

Because it wasn't very meaningful. When you had

  const x = 0
  // ...
  function x() {}

it would claim that "function x is already defined", which I find rather
misleading.

[rossberg, 2014-04-02 12:38:14]

Committed patchset #1 manually as r20434 (presubmit successful).