Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 220473013: Harden ScriptWrappable against ref count bugs (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
haraken, dcarney
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/bindings/v8/ScriptWrappable.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-02 11:23:01 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-02 11:23:59 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-02 11:26:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/220473013/1
6 years, 8 months ago (2014-04-02 11:26:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 13:49:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 13:49:32 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 8 months ago (2014-04-02 14:02:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/220473013/1
6 years, 8 months ago (2014-04-02 14:02:50 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 15:10:07 UTC) #9
Message was sent while issue was closed.
Change committed as 170658

Powered by Google App Engine
This is Rietveld 408576698