chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - Issue 2204713006: Add chrome://usb-internals page for adding and removing test devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2204713006: Add chrome://usb-internals page for adding and removing test devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed some of dpapad@'s comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/usb_internals/usb_internals.js ('K') | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/webui/usb_internals/BUILD.gn » ('j') | chrome/browser/ui/webui/usb_internals/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

index 7bed528aa0ec372b22f57545e149189f7f3b6756..f93135a7ed076c63ec8ce9fe1c920d7ca57f610d 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -55,6 +55,7 @@

#include "chrome/browser/ui/webui/supervised_user_internals_ui.h"

#include "chrome/browser/ui/webui/sync_internals_ui.h"

#include "chrome/browser/ui/webui/translate_internals/translate_internals_ui.h"

+#include "chrome/browser/ui/webui/usb_internals/usb_internals_ui.h"

#include "chrome/browser/ui/webui/user_actions/user_actions_ui.h"

#include "chrome/browser/ui/webui/version_ui.h"

#include "chrome/common/chrome_features.h"

@@ -376,6 +377,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,

return &NewWebUI<WebDialogUI>;

if (url.host() == chrome::kChromeUITranslateInternalsHost)

return &NewWebUI<TranslateInternalsUI>;

+ if (url.host() == chrome::kChromeUIUsbInternalsHost)

+ return &NewWebUI<UsbInternalsUI>;

if (url.host() == chrome::kChromeUIUserActionsHost)

return &NewWebUI<UserActionsUI>;

if (url.host() == chrome::kChromeUIVersionHost)