Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/browser/ui/webui/usb_internals/usb_internals.mojom

Issue 2204713006: Add chrome://usb-internals page for adding and removing test devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses dpapad@'s nits. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module mojom;
6
7 struct TestDeviceInfo {
8 string guid;
9 string name;
10 string serial_number;
11 string landing_page;
Robert Sesek 2016/08/08 19:11:35 Should this be a GURL?
Reilly Grant (use Gerrit) 2016/08/08 20:48:24 It should but since this interface is being called
Robert Sesek 2016/08/09 20:42:37 Is it? It looks like the user input is only for Ad
Reilly Grant (use Gerrit) 2016/08/10 01:02:46 Ah, I see what you mean. I was only looking at Add
12 string allowed_origin;
Robert Sesek 2016/08/08 19:11:35 And should this be a url::Origin?
13 };
14
15 interface UsbInternalsPageHandler {
16 // Simulate the connection of a new device with the given properties.
17 AddDeviceForTesting(string name,
18 string serial_number,
19 string landing_page,
20 string allowed_origin) => (bool success, string message);
21
22 // Simulate the disconnection of a device added with the function above.
23 RemoveDeviceForTesting(string guid) => ();
24
25 // Retrieves the list of test devices added with this API.
26 GetTestDevices() => (array<TestDeviceInfo> devices);
27 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698