Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2204683005: Enable SK_DEBUG/SK_RELEASE to be defined in the user config. (Closed)

Created:
4 years, 4 months ago by djsollen
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable SK_DEBUG/SK_RELEASE to be defined in the user config. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2204683005 Committed: https://skia.googlesource.com/skia/+/300405a7a21aea994061fc0fabaf13465fb31f09

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enable SK_DEBUG/SK_RELEASE to be defined in the user config. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +8 lines, -0 lines 0 comments Download
M include/core/SkPreConfig.h View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
djsollen
4 years, 4 months ago (2016-08-02 17:11:51 UTC) #3
mtklein
https://codereview.chromium.org/2204683005/diff/1/include/core/SkPreConfig.h File include/core/SkPreConfig.h (right): https://codereview.chromium.org/2204683005/diff/1/include/core/SkPreConfig.h#newcode55 include/core/SkPreConfig.h:55: #ifdef SK_BUILD_FOR_WIN32s typo?
4 years, 4 months ago (2016-08-02 17:13:00 UTC) #4
djsollen
https://codereview.chromium.org/2204683005/diff/1/include/core/SkPreConfig.h File include/core/SkPreConfig.h (right): https://codereview.chromium.org/2204683005/diff/1/include/core/SkPreConfig.h#newcode55 include/core/SkPreConfig.h:55: #ifdef SK_BUILD_FOR_WIN32s On 2016/08/02 17:13:00, mtklein wrote: > typo? ...
4 years, 4 months ago (2016-08-04 12:24:49 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-08-04 12:54:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204683005/20001
4 years, 4 months ago (2016-08-05 19:39:49 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 20:04:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/300405a7a21aea994061fc0fabaf13465fb31f09

Powered by Google App Engine
This is Rietveld 408576698