Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2204683003: Roll open-vcdiff 21d7d0b9:2b9bd1fe (Closed)

Created:
4 years, 4 months ago by Elly Fong-Jones
Modified:
4 years, 4 months ago
Reviewers:
Nico, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll open-vcdiff 21d7d0b9:2b9bd1fe Picks up cmake support and a new public interface, as well as some changes to the standalone binary targets. Full log: https://chromium.googlesource.com/external/github.com/google/open-vcdiff/+log/21d7d0b9..2b9bd1fe NOPRESUBMIT because updated generated config files have weird copyright headers in them. NOPRESUBMIT=true BUG= Committed: https://crrev.com/a4e1c71b4ded320f06bcdffcddbf559e91baa9e7 Cr-Commit-Position: refs/heads/master@{#411031}

Patch Set 1 #

Patch Set 2 : fix BUILD.gn #

Patch Set 3 : add win/config.h #

Patch Set 4 : regenerate configs #

Patch Set 5 : 682f6873 -> 2b9bd1fe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -292 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sdch/BUILD.gn View 1 3 chunks +2 lines, -4 lines 0 comments Download
M sdch/README.chromium View 1 2 3 1 chunk +19 lines, -16 lines 0 comments Download
M sdch/ios/config.h View 1 2 3 4 2 chunks +23 lines, -83 lines 0 comments Download
M sdch/linux/config.h View 1 2 3 4 1 chunk +25 lines, -91 lines 0 comments Download
M sdch/mac/config.h View 1 2 3 4 2 chunks +23 lines, -87 lines 0 comments Download
M sdch/win/config.h View 1 2 3 4 1 chunk +49 lines, -10 lines 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (32 generated)
Elly Fong-Jones
thakis: ptal? :)
4 years, 4 months ago (2016-08-03 14:18:28 UTC) #13
Nico
lgtm, but presubmit is unhappy about the config.h files not having licenses. The old ones ...
4 years, 4 months ago (2016-08-03 14:59:48 UTC) #20
Elly Fong-Jones
+torne for tools/copyright_scanner OWNER review I'm not sure what to do with these config files. ...
4 years, 4 months ago (2016-08-09 18:39:01 UTC) #22
Torne
copyright scanner stuff LGTM. This seems like the easiest way to work around this.
4 years, 4 months ago (2016-08-10 12:30:01 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204683003/80001
4 years, 4 months ago (2016-08-10 13:14:46 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204683003/80001
4 years, 4 months ago (2016-08-10 13:16:47 UTC) #36
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-10 13:17:48 UTC) #38
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 13:18:51 UTC) #40
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a4e1c71b4ded320f06bcdffcddbf559e91baa9e7
Cr-Commit-Position: refs/heads/master@{#411031}

Powered by Google App Engine
This is Rietveld 408576698