Cache API should not match() HEAD requests

content/browser/cache_storage/cache_storage_cache.cc

Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index 6dc652e7d3d00d2807912fb8ed3ab82d673e9854..25ebb8ff65806acc6d83e8818e983c36ae59c06d 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -692,6 +692,13 @@ void CacheStorageCache::MatchImpl(
     return;
   }
 
+  if (request->method == "HEAD") {
+    callback.Run(CACHE_STORAGE_ERROR_NOT_FOUND,
+                 std::unique_ptr<ServiceWorkerResponse>(),
+                 std::unique_ptr<storage::BlobDataHandle>());
+    return;
+  }
+
   std::unique_ptr<disk_cache::Entry*> scoped_entry_ptr(
       new disk_cache::Entry*());
   disk_cache::Entry** entry_ptr = scoped_entry_ptr.get();
@@ -790,6 +797,12 @@ void CacheStorageCache::MatchAllImpl(
     return;
   }
 
+  if (request && request->method == "HEAD") {

[jkarlin, 2016/08/04 14:50:40]

The updated spec reads that if it's a HEAD and options ignore_method is false,
return empty. We need to check ignore_method here.

[jkarlin, 2016/08/04 14:52:18]

This should really be a check to make sure that it's a GET.

[jsbell, 2016/08/04 23:49:17]

Done and done.

+    callback.Run(CACHE_STORAGE_OK, base::WrapUnique(new Responses),
+                 base::WrapUnique(new BlobDataHandles));
+    return;
+  }
+
   QueryCache(std::move(request), options,
              base::Bind(&CacheStorageCache::MatchAllDidQueryCache,
                         weak_ptr_factory_.GetWeakPtr(), callback));