WIP - WebMediaPlayer switch media renderer.

third_party/WebKit/Source/web/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "web/FullscreenController.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Fullscreen.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/PageScaleConstraintsSet.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLVideoElement.h"
+#include "platform/LayoutTestSupport.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "public/platform/WebLayerTreeView.h"
 #include "public/web/WebFrameClient.h"
+#include "third_party/WebKit/Source/core/dom/TagCollection.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebSettingsImpl.h"
 #include "web/WebViewImpl.h"
 
 namespace blink {
 
 FullscreenController* FullscreenController::create(WebViewImpl* webViewImpl)
 {
     return new FullscreenController(webViewImpl);
 }
@@ skipping 24 matching lines @@
         m_webViewImpl->setPageScaleFactor(1.0f);
         if (m_webViewImpl->mainFrame()->isWebLocalFrame())
             m_webViewImpl->mainFrame()->setScrollOffset(WebSize());
         m_webViewImpl->setVisualViewportOffset(FloatPoint());
         m_haveEnteredFullscreen = true;
     }
 
     Fullscreen::from(document).didEnterFullscreenForElement(element);
     DCHECK_EQ(Fullscreen::currentFullScreenElementFrom(document), element);
 
+    // Notify WebMediaPlayer when video enters full screen, and the full screen
+    // element is not a HTMLMediaElement.
+    if (!isHTMLMediaElement(element)) {

[liberato (no reviews please), 2016/08/03 21:54:17]

could early-out on isRunningLayoutTest here, rather than in the loop.

actually, there's a bunch of code that's identical between the enter / exit
cases.  maybe some helper:

HTMLMediaElement* FullscreenController::findChildMediaElement(element)

also, what is the desired behavior if
 - more than one media element exists under |element|?
 - a media element is not visible in the sense of css display:none?

[xjz, 2016/08/04 02:28:15]

Done with the helper. 
Yes, it could have multiple media elements under this |element| or/and invisible
elements. The desired behavior here is to notify each media element that its
parent goes to fullscreen. 

+        TagCollection* collection = element->getElementsByTagName("video");
+        for (unsigned i = 0; i < collection->length(); ++i) {
+            Element* collectElement = collection->item(i);
+            if (isHTMLMediaElement(collectElement)) {

[liberato (no reviews please), 2016/08/03 21:54:17]

if (!is)... continue; will save {} nesting.

[xjz, 2016/08/04 02:28:15]

Done. 

+                HTMLMediaElement* videoElement = toHTMLMediaElement(collectElement);
+                if (videoElement->webMediaPlayer()
+                    && !LayoutTestSupport::isRunningLayoutTest())
+                    videoElement->webMediaPlayer()->enteredFullscreen();

[liberato (no reviews please), 2016/08/03 21:54:17]

entered/exitedFullscreen shouldn't be called for an ancestor case. it will
trigger an optimization on android that will break standards conformance,
unfortunately.  my current project is to fix that.

i recommend adding something like ancestorEntered/ExitedFullscreen() to
WebMediaPlayer.  whatever processing fullscreen does for cast will have to
happen in both the ancestor and self cases, but most of the existing non-cast
logic will happen only in the self case.

[xjz, 2016/08/04 02:28:16]

I agree. Now add WebMediaPlayer::updateMediaInFullscreen() for this purpose, and
keep the original non-cast logic. 

+            }
+        }
+    }
+
     if (isHTMLVideoElement(element)) {
         HTMLVideoElement* videoElement = toHTMLVideoElement(element);
         if (videoElement->usesOverlayFullscreenVideo() && m_webViewImpl->layerTreeView())
             m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);
     }
 }
 
 void FullscreenController::didExitFullscreen()
 {
     if (!m_fullScreenFrame)
@@ skipping 15 matching lines @@
                 // If the video used overlay fullscreen mode, the background was made transparent. Restore the transparency.
                 if (isHTMLVideoElement(element) && m_webViewImpl->layerTreeView())
                     m_webViewImpl->layerTreeView()->setHasTransparentBackground(m_webViewImpl->isTransparent());
 
                 // We need to wait until style and layout are updated in order
                 // to propertly restore scroll offsets since content may not be
                 // overflowing in the same way until they do.
                 if (m_haveEnteredFullscreen)
                     m_needsScrollAndScaleRestore = true;
 
+                // Notify WebMediaPlayer when video exits full screen, and the
+                // full screen element is not a HTMLMediaElement.
+                if (!isHTMLMediaElement(element)) {
+                    TagCollection* collection = element->getElementsByTagName("video");
+                    for (unsigned i = 0; i < collection->length(); ++i) {
+                        Element* collectElement = collection->item(i);
+                        if (isHTMLMediaElement(collectElement)) {
+                            HTMLMediaElement* videoElement = toHTMLMediaElement(collectElement);
+                            if (videoElement->webMediaPlayer())
+                                videoElement->webMediaPlayer()->exitedFullscreen();
+                        }
+                    }
+                }
+
                 fullscreen->didExitFullscreen();
             }
         }
     }
 
     m_haveEnteredFullscreen = false;
     m_fullScreenFrame.clear();
 }
 
 void FullscreenController::enterFullScreenForElement(Element* element)
@@ skipping 109 matching lines @@
     m_webViewImpl->updateMainFrameLayoutSize();
 }
 
 DEFINE_TRACE(FullscreenController)
 {
     visitor->trace(m_provisionalFullScreenElement);
     visitor->trace(m_fullScreenFrame);
 }
 
 } // namespace blink