Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2204593011: Reload: Have dangling extracted properties raise NoSuchMethod. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reload: Have dangling extracted properties raise NoSuchMethod. Closes #26995 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5f4a685cd7fe55d4d15e7e37eec905d999d43e08

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git cl description #

Patch Set 4 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -22 lines) Patch
M runtime/vm/isolate_reload_test.cc View 1 chunk +348 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 2 chunks +68 lines, -22 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
rmacnak
4 years, 4 months ago (2016-08-04 00:03:42 UTC) #4
Cutch
LGTM with a question https://codereview.chromium.org/2204593011/diff/60001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2204593011/diff/60001/runtime/vm/parser.cc#newcode1555 runtime/vm/parser.cc:1555: &Symbols::Value(), why drop the field ...
4 years, 4 months ago (2016-08-04 00:38:05 UTC) #5
rmacnak
https://chromiumcodereview.appspot.com/2204593011/diff/60001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/2204593011/diff/60001/runtime/vm/parser.cc#newcode1555 runtime/vm/parser.cc:1555: &Symbols::Value(), On 2016/08/04 00:38:05, Cutch wrote: > why drop ...
4 years, 4 months ago (2016-08-04 16:19:31 UTC) #6
Cutch
LGTM
4 years, 4 months ago (2016-08-04 16:23:07 UTC) #7
rmacnak
4 years, 4 months ago (2016-08-04 16:54:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
5f4a685cd7fe55d4d15e7e37eec905d999d43e08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698