Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2204593010: Introduce a bazel provider (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
Harry Terkelsen, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -25 lines) Patch
M pkg/compiler/bin/resolver.dart View 3 chunks +17 lines, -3 lines 0 comments Download
M pkg/compiler/lib/compiler_new.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 6 chunks +94 lines, -20 lines 4 comments Download

Messages

Total messages: 12 (6 generated)
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-08 22:15:00 UTC) #5
Harry Terkelsen
lgtm https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart File pkg/compiler/lib/src/source_file_provider.dart (right): https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart#newcode386 pkg/compiler/lib/src/source_file_provider.dart:386: /// THe current working directory will be used ...
4 years, 4 months ago (2016-08-08 23:15:30 UTC) #6
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart File pkg/compiler/lib/src/source_file_provider.dart (right): https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart#newcode386 pkg/compiler/lib/src/source_file_provider.dart:386: /// THe current working directory will be used to ...
4 years, 4 months ago (2016-08-08 23:16:17 UTC) #7
kevmoo
DBC https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart File pkg/compiler/lib/src/source_file_provider.dart (right): https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/source_file_provider.dart#newcode402 pkg/compiler/lib/src/source_file_provider.dart:402: var config = new File(configPath).readAsStringSync().split('\n'); Or new File(...).readAsLines() ...
4 years, 4 months ago (2016-08-08 23:19:24 UTC) #9
Siggi Cherem (dart-lang)
Committed patchset #1 (id:60001) manually as eac954b3dcd82e5c406731009f634e69dc50c03d (presubmit successful).
4 years, 4 months ago (2016-08-08 23:57:26 UTC) #11
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-08 23:57:37 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/so...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/2204593010/diff/60001/pkg/compiler/lib/src/so...
pkg/compiler/lib/src/source_file_provider.dart:402: var config = new
File(configPath).readAsStringSync().split('\n');
On 2016/08/08 23:19:23, kevmoo wrote:
> Or new File(...).readAsLines() ?

neat - done.

Powered by Google App Engine
This is Rietveld 408576698