Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2204593005: Revert of [heap] Re-enable black allocation when finalizing marking. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Re-enable black allocation when finalizing marking. (patchset #1 id:1 of https://codereview.chromium.org/2202993002/ ) Reason for revert: Crashes on tree. Original issue's description: > [heap] Re-enable black allocation when finalizing marking. > > BUG=chromium:630386 > LOG=n > > Committed: https://crrev.com/2c75cfd731e11daa649faf2e91cbb84767b11f8e > Cr-Commit-Position: refs/heads/master@{#38240} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630386 Committed: https://crrev.com/682c4e448e97e9106ab00d3a5c8297e358016915 Cr-Commit-Position: refs/heads/master@{#38243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Re-enable black allocation when finalizing marking.
4 years, 4 months ago (2016-08-02 12:26:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204593005/1
4 years, 4 months ago (2016-08-02 12:26:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 12:27:00 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 12:29:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/682c4e448e97e9106ab00d3a5c8297e358016915
Cr-Commit-Position: refs/heads/master@{#38243}

Powered by Google App Engine
This is Rietveld 408576698