third_party/WebKit/Source/core/layout/api/LineLayoutItem.h - Issue 2204593003: Change requiresLineBox to return false for empty-text inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

Issue 2204593003: Change requiresLineBox to return false for empty-text inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove curly brackets around one-line control-flow statements Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-generated-content/pseudo-inline-with-empty-content-expected.html ('k') | third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

diff --git a/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h b/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

index a96cf45cf3110a3d95928e187bd295b197796343..a17d558ca2c0d9e88f7e8849230b80c679a40b1c 100644

--- a/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

+++ b/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

@@ -7,6 +7,7 @@

#include "core/layout/LayoutObject.h"

#include "core/layout/LayoutObjectInlines.h"

+#include "core/layout/LayoutText.h"

#include "platform/LayoutUnit.h"

#include "wtf/Allocator.h"

@@ -316,6 +317,11 @@ public:

return m_layoutObject->isText();

}

+ bool isEmptyText() const

+ {

+ return isText() && toLayoutText(m_layoutObject)->text().isEmpty();

+ }

bool hasLayer() const

{

return m_layoutObject->hasLayer();