Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2204593003: Change requiresLineBox to return false for empty-text inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix in requiresLineBox Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
index 62ceade42a907e4930d366840be62c3e9f2c5da1..ab0f1baaae981cee6baffa0cf8a143ce2ce54388 100644
--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
@@ -206,6 +206,10 @@ inline bool alwaysRequiresLineBox(LineLayoutItem flow)
inline bool requiresLineBox(const InlineIterator& it, const LineInfo& lineInfo = LineInfo(), WhitespacePosition whitespacePosition = LeadingWhitespace)
{
+ if (it.getLineLayoutItem().isEmptyText()) {
eae 2016/08/02 20:52:04 NIT: No curly brackets around one-line control-flo
Gleb Lanbin 2016/08/02 23:17:55 Done.
+ return false;
+ }
+
if (it.getLineLayoutItem().isFloatingOrOutOfFlowPositioned())
return false;
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698