Cache API should reject 206 Partial Responses

Cache API should reject 206 Partial Responses

Per spec issue[1], the cache API should reject partial responses,
failing calls to put()/add()/addAll() that come back with an HTTP
status code 206.

[1] https://github.com/slightlyoff/ServiceWorker/issues/937

R=jkarlin@chromium.org,cmumford@chromium.org
BUG=633338
Committed: https://crrev.com/7ca1d2fef66579fe8ebf3f7580da56c9f9cd3a48
Cr-Commit-Position: refs/heads/master@{#409314}

[jsbell, 2016-08-01 21:02:28]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 21:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-08-01 21:03:34]

jkarlin@, cmumford@ - please take a look?

(sorry for sniping the easy one!)

[commit-bot: I haz the power, 2016-08-01 22:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:39:27]

Dry run: This issue passed the CQ dry run.

[cmumford, 2016-08-02 13:26:12]

lgtm

[jkarlin, 2016-08-02 13:47:51]

lgtm with comment

https://codereview.chromium.org/2204573002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js
(right):

https://codereview.chromium.org/2204573002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js:114:
cache.addAll(['../resources/fetch-status.php?status=206']),
Can you put two requests in the addAll, where the first isn't a 206? We should
make sure the whole operation fails.

[jsbell, 2016-08-02 18:59:42]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-08-02 18:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/2204573002/#ps20001
(title: "Give addAll a working resource, to show the whole shebang fails")

[commit-bot: I haz the power, 2016-08-02 19:00:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-08-02 19:54:10]

https://codereview.chromium.org/2204573002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js
(right):

https://codereview.chromium.org/2204573002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js:114:
cache.addAll(['../resources/fetch-status.php?status=206']),
On 2016/08/02 13:47:51, jkarlin wrote:
> Can you put two requests in the addAll, where the first isn't a 206? We should
> make sure the whole operation fails.

Good idea - done!

(I didn't verify that the cache is untouched on failure, since that's covered by
other tests. I don't think every permutation is necessary, but can be persuaded
otherwise.)

[commit-bot: I haz the power, 2016-08-02 20:45:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 20:49:16]

Description was changed from

==========
Cache API should reject 206 Partial Responses

Per spec issue[1], the cache API should reject partial responses,
failing calls to put()/add()/addAll() that come back with an HTTP
status code 206.

[1] https://github.com/slightlyoff/ServiceWorker/issues/937

R=jkarlin@chromium.org,cmumford@chromium.org
BUG=633338
==========

to

==========
Cache API should reject 206 Partial Responses

Per spec issue[1], the cache API should reject partial responses,
failing calls to put()/add()/addAll() that come back with an HTTP
status code 206.

[1] https://github.com/slightlyoff/ServiceWorker/issues/937

R=jkarlin@chromium.org,cmumford@chromium.org
BUG=633338

Committed: https://crrev.com/7ca1d2fef66579fe8ebf3f7580da56c9f9cd3a48
Cr-Commit-Position: refs/heads/master@{#409314}
==========

[commit-bot: I haz the power, 2016-08-02 20:49:17]

Patchset 2 (id:??) landed as
https://crrev.com/7ca1d2fef66579fe8ebf3f7580da56c9f9cd3a48
Cr-Commit-Position: refs/heads/master@{#409314}