runtime/observatory/lib/utils.dart - Issue 2204563003: Converted Observatory cpu-profile element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/utils.dart

Issue 2204563003: Converted Observatory cpu-profile element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Added lifecycle tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/utils.dart

diff --git a/runtime/observatory/lib/utils.dart b/runtime/observatory/lib/utils.dart

index cfc447c7c5cffd5f935ce5f19a9fb0ff04b24fa2..a73916f0cdaa951226f5530a4fcaaa0711295f3c 100644

--- a/runtime/observatory/lib/utils.dart

+++ b/runtime/observatory/lib/utils.dart

@@ -146,6 +146,10 @@ class Utils {

return x.toStringAsFixed(2);

}

+ static String formatDurationInSeconds(Duration x) {

+ return formatSeconds(x.inMilliseconds / 1000.0);

Cutch 2016/08/09 20:21:52 return formatSeconds(x.inSeconds);

cbernaschina 2016/08/09 20:29:39 it is not equivalent. x.inMilliseconds / 1000.0 (

+ }

static bool runningInJavaScript() => identical(1.0, 1);

}