Converted Observatory cpu-profile element

Converted Observatory cpu-profile element

Fixes https://github.com/dart-lang/sdk/issues/26043

R=johnmccutchan@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ce171ac336c36283005c37ffd2aa096ae58bc24

[cbernaschina, 2016-08-02 01:18:38]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[cbernaschina, 2016-08-02 02:42:12]

Description was changed from

==========
Converted Observatory cpi-profile element

Initial CL still checking
==========

to

==========
Converted Observatory cpu-profile element

Initial CL still checking
==========

[Cutch, 2016-08-02 15:52:20]

some initial comments

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:53: /// A [SimplePage] matches a
single uri path and displays a single element.
fix documentation comment

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:239: return new VMUpdateEventMock(vm:
isolate.vm);
why are mocks present here?

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:31: _r.onRendered;
weird indentation

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:105: t = new
VirtualTreeElement((toggle) {
could this closure be turned into a named method?

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:156: t = new
VirtualTreeElement((toggle) {
could this closure be turned into a named method?

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile_table.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile_table.dart:627: new
StackTraceTreeConfigElement(showMode: false, showDirection: false,
fix long lines

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/sample_buffer_control.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/sample_buffer_control.dart:225: /*Future
_changeState(SampleBufferState newState, [exception, stackTrace]) {
delete commented out code

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/stack_trace_tree_config.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/stack_trace_tree_config.dart:11: Inclusive,
enum values are lowerCamelCase

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/repositories/sample_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/repositories/sample_profile.dart:102: (() async {
is this invoked?

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/obs...
File runtime/observatory/observatory_sources.gypi (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/obs...
runtime/observatory/observatory_sources.gypi:64:
'lib/src/elements/eval_link.html',
are there new files that need to be listed here?

[cbernaschina, 2016-08-02 17:40:25]

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:53: /// A [SimplePage] matches a
single uri path and displays a single element.
On 2016/08/02 15:52:19, Cutch wrote:
> fix documentation comment

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:239: return new VMUpdateEventMock(vm:
isolate.vm);
On 2016/08/02 15:52:19, Cutch wrote:
> why are mocks present here?

I'm building up another CL where all the Events comes from a centralized set o
streams. This is a temporary workaround.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:31: _r.onRendered;
On 2016/08/02 15:52:20, Cutch wrote:
> weird indentation

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:105: t = new
VirtualTreeElement((toggle) {
On 2016/08/02 15:52:20, Cutch wrote:
> could this closure be turned into a named method?

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:156: t = new
VirtualTreeElement((toggle) {
On 2016/08/02 15:52:20, Cutch wrote:
> could this closure be turned into a named method?

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile_table.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile_table.dart:627: new
StackTraceTreeConfigElement(showMode: false, showDirection: false,
On 2016/08/02 15:52:20, Cutch wrote:
> fix long lines

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/sample_buffer_control.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/sample_buffer_control.dart:225: /*Future
_changeState(SampleBufferState newState, [exception, stackTrace]) {
On 2016/08/02 15:52:20, Cutch wrote:
> delete commented out code

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/stack_trace_tree_config.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/stack_trace_tree_config.dart:11: Inclusive,
On 2016/08/02 15:52:20, Cutch wrote:
> enum values are lowerCamelCase
> 

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/repositories/sample_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/repositories/sample_profile.dart:102: (() async {
On 2016/08/02 15:52:20, Cutch wrote:
> is this invoked?

Done.

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/obs...
File runtime/observatory/observatory_sources.gypi (right):

https://codereview.chromium.org/2204563003/diff/40001/runtime/observatory/obs...
runtime/observatory/observatory_sources.gypi:64:
'lib/src/elements/eval_link.html',
On 2016/08/02 15:52:20, Cutch wrote:
> are there new files that need to be listed here?

Done.

[cbernaschina, 2016-08-03 16:53:48]

Description was changed from

==========
Converted Observatory cpu-profile element

Initial CL still checking
==========

to

==========
Converted Observatory cpu-profile element

Initial CL still checking

Fixes https://github.com/dart-lang/sdk/issues/26043
==========

[Cutch, 2016-08-04 15:35:52]

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:647: static const
double MICROSECONDS_PER_SECOND = 1000000.0;
Please switch this to use the constants defined on the Duration class:

https://api.dartlang.org/stable/1.18.1/dart-core/Duration-class.html

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:649: static const
double displayThreshold = 0.0002; // 0.02%.
please remove the displayThreshold (it's unnecessary now that the virtual tree
renders so quickly)

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/stack_trace_tree_config.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/stack_trace_tree_config.dart:228: /*<link
rel="import" href="../../../../packages/polymer/polymer.html">
delete commented out code

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/models/repositories/sample_profile.dart
(right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/models/repositories/sample_profile.dart:8: UserVM,
lowerCamelCase (here and elsewhere)

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/repositories/sample_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/repositories/sample_profile.dart:9: case
M.SampleProfileTag.UserVM : return 'UserVM';
no space between the case value and the colon (:)

[cbernaschina, 2016-08-04 19:45:08]

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:647: static const
double MICROSECONDS_PER_SECOND = 1000000.0;
On 2016/08/04 15:35:52, Cutch wrote:
> Please switch this to use the constants defined on the Duration class:
> 
> https://api.dartlang.org/stable/1.18.1/dart-core/Duration-class.html

Done.

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:649: static const
double displayThreshold = 0.0002; // 0.02%.
On 2016/08/04 15:35:52, Cutch wrote:
> please remove the displayThreshold (it's unnecessary now that the virtual tree
> renders so quickly)

Done.

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/stack_trace_tree_config.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/stack_trace_tree_config.dart:228: /*<link
rel="import" href="../../../../packages/polymer/polymer.html">
On 2016/08/04 15:35:52, Cutch wrote:
> delete commented out code

Done.

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/models/repositories/sample_profile.dart
(right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/models/repositories/sample_profile.dart:8: UserVM,
On 2016/08/04 15:35:52, Cutch wrote:
> lowerCamelCase (here and elsewhere)

Done.

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/repositories/sample_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/repositories/sample_profile.dart:9: case
M.SampleProfileTag.UserVM : return 'UserVM';
On 2016/08/04 15:35:52, Cutch wrote:
> no space between the case value and the colon (:)

Done.

[cbernaschina, 2016-08-09 19:18:27]

Description was changed from

==========
Converted Observatory cpu-profile element

Initial CL still checking

Fixes https://github.com/dart-lang/sdk/issues/26043
==========

to

==========
Converted Observatory cpu-profile element

Fixes https://github.com/dart-lang/sdk/issues/26043
==========

[Cutch, 2016-08-09 20:21:53]

LGTM but Ryan should review this one too.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:734: if (count % 256 ==
0 && watch.elapsedMilliseconds > 16) {
our style is this:

if (((count % 256) == 0) && (watch.elapsedMilliseconds > 16))

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:772: if
(needToUpdate()) { await signal(count * 100 / length); }
new line and indent

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/cpu_profile_table.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/cpu_profile_table.dart:903: if
(cpuProfileTreeElement == null) { return; }
newline indent

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/utils.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/utils.dart:150: return formatSeconds(x.inMilliseconds /
1000.0);
return formatSeconds(x.inSeconds);

[cbernaschina, 2016-08-09 20:29:39]

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/cpu_profile/cpu_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:734: if (count % 256 ==
0 && watch.elapsedMilliseconds > 16) {
On 2016/08/09 20:21:52, Cutch wrote:
> our style is this:
> 
> if (((count % 256) == 0) && (watch.elapsedMilliseconds > 16)) 

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/cpu_profile/cpu_profile.dart:772: if
(needToUpdate()) { await signal(count * 100 / length); }
On 2016/08/09 20:21:52, Cutch wrote:
> new line and indent

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/cpu_profile_table.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/cpu_profile_table.dart:903: if
(cpuProfileTreeElement == null) { return; }
On 2016/08/09 20:21:52, Cutch wrote:
> newline indent

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/utils.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/utils.dart:150: return formatSeconds(x.inMilliseconds /
1000.0);
On 2016/08/09 20:21:52, Cutch wrote:
> return formatSeconds(x.inSeconds);

it is not equivalent.

x.inMilliseconds / 1000.0
(or better x.inMilliseconds / Duration.MILLISECONDS_PER_SECOND)
is a double

x.inSeconds
is a int

[rmacnak, 2016-08-09 20:51:07]

lgtm w/c

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/class_view.dart:76: loads.add(await
cls.reload());
List constructed but not used.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:95: throw new
Exception('Unknown ProfileTreeMode');
'Unknown ProfileTreeMode: $mode'

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/helpers/uris.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/helpers/uris.dart:46: =>
_isolatePage('/ports', isolate);
profiler

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/repositories/sample_profile.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/repositories/sample_profile.dart:15: throw new
Exception('Unknown SampleProfileTag');
'Unknown SampleProfileTag: $tag'

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File runtime/observatory/tests/observatory_ui/cpu_profile/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/element_test.dart:4: import
'dart:html';
blank line after copyright

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart:4:
import 'dart:html';
blank line

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart:10:
main(){
main() {

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File
runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.dart:4:
import 'dart:html';
blank line

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart:4:
import 'dart:html';
blank line

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart:9:
main(){
main() {

[cbernaschina, 2016-08-09 21:16:55]

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/class_view.dart:76: loads.add(await
cls.reload());
On 2016/08/09 20:51:06, rmacnak wrote:
> List constructed but not used.

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart:95: throw new
Exception('Unknown ProfileTreeMode');
On 2016/08/09 20:51:06, rmacnak wrote:
> 'Unknown ProfileTreeMode: $mode'

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/helpers/uris.dart (right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/li...
runtime/observatory/lib/src/elements/helpers/uris.dart:46: =>
_isolatePage('/ports', isolate);
On 2016/08/09 20:51:06, rmacnak wrote:
> profiler

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File runtime/observatory/tests/observatory_ui/cpu_profile/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/element_test.dart:4: import
'dart:html';
On 2016/08/09 20:51:06, rmacnak wrote:
> blank line after copyright

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart:4:
import 'dart:html';
On 2016/08/09 20:51:06, rmacnak wrote:
> blank line

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.dart:10:
main(){
On 2016/08/09 20:51:06, rmacnak wrote:
> main() {

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
File
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart
(right):

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart:4:
import 'dart:html';
On 2016/08/09 20:51:06, rmacnak wrote:
> blank line

Done.

https://codereview.chromium.org/2204563003/diff/280001/runtime/observatory/te...
runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.dart:9:
main(){
On 2016/08/09 20:51:06, rmacnak wrote:
> main() {

Done.

[cbernaschina, 2016-08-09 21:34:10]

Description was changed from

==========
Converted Observatory cpu-profile element

Fixes https://github.com/dart-lang/sdk/issues/26043
==========

to

==========
Converted Observatory cpu-profile element

Fixes https://github.com/dart-lang/sdk/issues/26043

R=johnmccutchan@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ce171ac336c36283005c37ffd2aa096ae58bc24
==========

[cbernaschina, 2016-08-09 21:34:12]

Committed patchset #18 (id:340001) manually as
9ce171ac336c36283005c37ffd2aa096ae58bc24 (presubmit successful).