| Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
|
| diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
|
| similarity index 82%
|
| rename from components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java
|
| rename to components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
|
| index 53e1850f2770b601a0fc90985056c60d3f2cd2be..9bc276b072817930360d6f0af2a405050b666416 100644
|
| --- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java
|
| +++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
|
| @@ -9,7 +9,6 @@ import static org.chromium.base.CollectionUtil.newHashSet;
|
| import android.test.suitebuilder.annotation.SmallTest;
|
|
|
| import org.chromium.base.test.util.Feature;
|
| -import org.chromium.net.CronetEngine.UrlRequestInfo;
|
| import org.chromium.net.test.EmbeddedTestServer;
|
|
|
| import java.util.ArrayList;
|
| @@ -20,9 +19,9 @@ import java.util.NoSuchElementException;
|
| import java.util.concurrent.Executor;
|
|
|
| /**
|
| - * Test RequestFinishedListener and the metrics information it provides.
|
| + * Test RequestFinishedInfo.Listener and the metrics information it provides.
|
| */
|
| -public class RequestFinishedListenerTest extends CronetTestBase {
|
| +public class RequestFinishedInfoTest extends CronetTestBase {
|
| CronetTestFramework mTestFramework;
|
| private EmbeddedTestServer mTestServer;
|
| private String mUrl;
|
| @@ -83,15 +82,15 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| }
|
| }
|
|
|
| - private static class TestRequestFinishedListener extends RequestFinishedListener {
|
| - private UrlRequestInfo mRequestInfo;
|
| + private static class TestRequestFinishedListener extends RequestFinishedInfo.Listener {
|
| + private RequestFinishedInfo mRequestInfo;
|
|
|
| public TestRequestFinishedListener(Executor executor) {
|
| super(executor);
|
| }
|
|
|
| @Override
|
| - public void onRequestFinished(UrlRequestInfo requestInfo) {
|
| + public void onRequestFinished(RequestFinishedInfo requestInfo) {
|
| assertNull("onRequestFinished called repeatedly", mRequestInfo);
|
| assertNotNull(requestInfo);
|
| mRequestInfo = requestInfo;
|
| @@ -117,14 +116,14 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| callback.blockForDone();
|
| testExecutor.runAllTasks();
|
|
|
| - CronetEngine.UrlRequestInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| - assertNotNull("RequestFinishedListener must be called", requestInfo);
|
| + RequestFinishedInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| + assertNotNull("RequestFinishedInfo.Listener must be called", requestInfo);
|
| assertEquals(mUrl, requestInfo.getUrl());
|
| assertNotNull(requestInfo.getResponseInfo());
|
| assertEquals(newHashSet("request annotation", this), // Use sets for unordered comparison.
|
| new HashSet<Object>(requestInfo.getAnnotations()));
|
| - CronetEngine.UrlRequestMetrics metrics = requestInfo.getMetrics();
|
| - assertNotNull("UrlRequestInfo.getMetrics() must not be null", metrics);
|
| + RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
|
| + assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
|
| assertTrue(metrics.getTotalTimeMs() > 0);
|
| assertTrue(metrics.getTotalTimeMs() >= metrics.getTtfbMs());
|
| assertTrue(metrics.getReceivedBytesCount() > 0);
|
| @@ -149,14 +148,14 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| .start();
|
| callback.blockForDone();
|
|
|
| - CronetEngine.UrlRequestInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| - assertNotNull("RequestFinishedListener must be called", requestInfo);
|
| + RequestFinishedInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| + assertNotNull("RequestFinishedInfo.Listener must be called", requestInfo);
|
| assertEquals(mUrl, requestInfo.getUrl());
|
| assertNotNull(requestInfo.getResponseInfo());
|
| assertEquals(newHashSet("request annotation", this), // Use sets for unordered comparison.
|
| new HashSet<Object>(requestInfo.getAnnotations()));
|
| - CronetEngine.UrlRequestMetrics metrics = requestInfo.getMetrics();
|
| - assertNotNull("UrlRequestInfo.getMetrics() must not be null", metrics);
|
| + RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
|
| + assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
|
| assertTrue(metrics.getTotalTimeMs() > 0);
|
| assertTrue(metrics.getTotalTimeMs() >= metrics.getTtfbMs());
|
| assertTrue(metrics.getReceivedBytesCount() > 0);
|
| @@ -183,10 +182,10 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| callback.blockForDone();
|
| testExecutor.joinAll();
|
|
|
| - CronetEngine.UrlRequestInfo firstRequestInfo = firstListener.mRequestInfo;
|
| - CronetEngine.UrlRequestInfo secondRequestInfo = secondListener.mRequestInfo;
|
| - assertNotNull("First RequestFinishedListener must be called", firstRequestInfo);
|
| - assertNotNull("Second RequestFinishedListener must be called", secondRequestInfo);
|
| + RequestFinishedInfo firstRequestInfo = firstListener.mRequestInfo;
|
| + RequestFinishedInfo secondRequestInfo = secondListener.mRequestInfo;
|
| + assertNotNull("First RequestFinishedInfo.Listener must be called", firstRequestInfo);
|
| + assertNotNull("Second RequestFinishedInfo.Listener must be called", secondRequestInfo);
|
| assertEquals(mUrl, firstRequestInfo.getUrl());
|
| assertEquals(mUrl, secondRequestInfo.getUrl());
|
| assertNotNull(firstRequestInfo.getResponseInfo());
|
| @@ -195,13 +194,13 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| new HashSet<Object>(firstRequestInfo.getAnnotations()));
|
| assertEquals(newHashSet("request annotation", this),
|
| new HashSet<Object>(secondRequestInfo.getAnnotations()));
|
| - CronetEngine.UrlRequestMetrics firstMetrics = firstRequestInfo.getMetrics();
|
| - assertNotNull("UrlRequestInfo.getMetrics() must not be null", firstMetrics);
|
| + RequestFinishedInfo.Metrics firstMetrics = firstRequestInfo.getMetrics();
|
| + assertNotNull("RequestFinishedInfo.getMetrics() must not be null", firstMetrics);
|
| assertTrue(firstMetrics.getTotalTimeMs() > 0);
|
| assertTrue(firstMetrics.getTotalTimeMs() >= firstMetrics.getTtfbMs());
|
| assertTrue(firstMetrics.getReceivedBytesCount() > 0);
|
| - CronetEngine.UrlRequestMetrics secondMetrics = secondRequestInfo.getMetrics();
|
| - assertNotNull("UrlRequestInfo.getMetrics() must not be null", secondMetrics);
|
| + RequestFinishedInfo.Metrics secondMetrics = secondRequestInfo.getMetrics();
|
| + assertNotNull("RequestFinishedInfo.getMetrics() must not be null", secondMetrics);
|
| assertTrue(secondMetrics.getTotalTimeMs() > 0);
|
| assertTrue(secondMetrics.getTotalTimeMs() >= secondMetrics.getTtfbMs());
|
| assertTrue(secondMetrics.getReceivedBytesCount() > 0);
|
| @@ -226,12 +225,12 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| assertTrue(callback.mOnErrorCalled);
|
| testExecutor.runAllTasks();
|
|
|
| - CronetEngine.UrlRequestInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| - assertNotNull("RequestFinishedListener must be called", requestInfo);
|
| + RequestFinishedInfo requestInfo = requestFinishedListener.mRequestInfo;
|
| + assertNotNull("RequestFinishedInfo.Listener must be called", requestInfo);
|
| assertEquals(connectionRefusedUrl, requestInfo.getUrl());
|
| assertTrue(requestInfo.getAnnotations().isEmpty());
|
| - CronetEngine.UrlRequestMetrics metrics = requestInfo.getMetrics();
|
| - assertNotNull("UrlRequestInfo.getMetrics() must not be null", metrics);
|
| + RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
|
| + assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
|
| // The failure is occasionally fast enough that time reported is 0, so just check for null
|
| assertNotNull(metrics.getTotalTimeMs());
|
| assertNull(metrics.getTtfbMs());
|
| @@ -256,8 +255,8 @@ public class RequestFinishedListenerTest extends CronetTestBase {
|
| callback.blockForDone();
|
| testExecutor.runAllTasks();
|
|
|
| - assertNull(
|
| - "RequestFinishedListener must not be called", requestFinishedListener.mRequestInfo);
|
| + assertNull("RequestFinishedInfo.Listener must not be called",
|
| + requestFinishedListener.mRequestInfo);
|
| mTestFramework.mCronetEngine.shutdown();
|
| }
|
| }
|
|
|