components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java - Issue 2204533002: Move Cronet metrics-related classes into their own files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2204533002: Move Cronet metrics-related classes into their own files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

index c0aa6e54dfd0b5427aa34a52ba13d15d80943cad..bfd67cd2f464741d8a5851e2c5c991cb496ff242 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

@@ -22,6 +22,7 @@ import org.chromium.net.BidirectionalStream;

import org.chromium.net.CronetEngine;

import org.chromium.net.NetworkQualityRttListener;

import org.chromium.net.NetworkQualityThroughputListener;

+import org.chromium.net.RequestFinishedInfo;

import org.chromium.net.RequestFinishedListener;

import org.chromium.net.UrlRequest;

import org.chromium.net.urlconnection.CronetHttpURLConnection;

@@ -476,7 +477,7 @@ public class CronetUrlRequestContext extends CronetEngine {

}

void reportFinished(final CronetUrlRequest request) {

- final UrlRequestInfo requestInfo = request.getRequestInfo();

+ final RequestFinishedInfo requestInfo = request.getRequestInfo();

ArrayList<RequestFinishedListener> currentListeners;

synchronized (mFinishedListenerLock) {

currentListeners = new ArrayList<RequestFinishedListener>(mFinishedListenerList);